[Piglit] [PATCH piglit 1/3] texsubimage: Fix updating a sub-region of a 3D texture
Brian Paul
brianp at vmware.com
Wed Dec 17 12:56:15 PST 2014
On 12/17/2014 10:45 AM, Neil Roberts wrote:
> When the texture target is GL_TEXTURE_3D the test wasn't updating a
> sub-region of the texture due to what looks like a typo. The test was
> passing anyway because the data it uploads is the same as the original
> data so doing nothing is valid behaviour according to the test.
> ---
> tests/texturing/texsubimage.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/texturing/texsubimage.c b/tests/texturing/texsubimage.c
> index f5b9209..0388da6 100644
> --- a/tests/texturing/texsubimage.c
> +++ b/tests/texturing/texsubimage.c
> @@ -298,7 +298,7 @@ test_format(GLenum target, GLenum intFormat)
> glTexSubImage2D(target, 0, tx, ty, tw, th,
> srcFormat, GL_UNSIGNED_BYTE, img);
> }
> - else if (target == GL_TEXTURE_2D) {
> + else if (target == GL_TEXTURE_3D) {
> glTexSubImage3D(target, 0, tx, ty, tz, tw, th, td,
> srcFormat, GL_UNSIGNED_BYTE, img);
> }
>
The series LGTM. Reviewed-by: Brian Paul <brianp at vmware.com>
Thanks.
More information about the Piglit
mailing list