[Piglit] [PATCH] arb_gpu_shader5: add compiler/invocations_count_too_large test

Jordan Justen jordan.l.justen at intel.com
Tue Feb 4 17:03:10 PST 2014


This test makes sure that a compile error is generated if
the invocations count is too large.

Signed-off-by: Jordan Justen <jordan.l.justen at intel.com>
---
 tests/all.py                                       |   1 +
 tests/spec/arb_gpu_shader5/CMakeLists.txt          |   1 +
 .../arb_gpu_shader5/compiler/CMakeLists.gl.txt     |  12 +++
 tests/spec/arb_gpu_shader5/compiler/CMakeLists.txt |   1 +
 .../compiler/invocations_count_too_large.c         | 119 +++++++++++++++++++++
 5 files changed, 134 insertions(+)
 create mode 100644 tests/spec/arb_gpu_shader5/compiler/CMakeLists.gl.txt
 create mode 100644 tests/spec/arb_gpu_shader5/compiler/CMakeLists.txt
 create mode 100644 tests/spec/arb_gpu_shader5/compiler/invocations_count_too_large.c

diff --git a/tests/all.py b/tests/all.py
index b8d0edb..34002fc 100644
--- a/tests/all.py
+++ b/tests/all.py
@@ -1731,6 +1731,7 @@ for stage in ['vs', 'fs']:
             arb_gpu_shader5[testname] = concurrent_test(cmd)
 add_concurrent_test(arb_gpu_shader5, 'arb_gpu_shader5-minmax')
 add_concurrent_test(arb_gpu_shader5, 'arb_gpu_shader5-invocation-id')
+add_concurrent_test(arb_gpu_shader5, 'arb_gpu_shader5-invocations_count_too_large')
 
 arb_texture_query_levels = Group()
 spec['ARB_texture_query_levels'] = arb_texture_query_levels
diff --git a/tests/spec/arb_gpu_shader5/CMakeLists.txt b/tests/spec/arb_gpu_shader5/CMakeLists.txt
index c376334..f41c000 100644
--- a/tests/spec/arb_gpu_shader5/CMakeLists.txt
+++ b/tests/spec/arb_gpu_shader5/CMakeLists.txt
@@ -1,2 +1,3 @@
+add_subdirectory (compiler)
 add_subdirectory (execution)
 piglit_include_target_api()
\ No newline at end of file
diff --git a/tests/spec/arb_gpu_shader5/compiler/CMakeLists.gl.txt b/tests/spec/arb_gpu_shader5/compiler/CMakeLists.gl.txt
new file mode 100644
index 0000000..2940b90
--- /dev/null
+++ b/tests/spec/arb_gpu_shader5/compiler/CMakeLists.gl.txt
@@ -0,0 +1,12 @@
+include_directories(
+	${GLEXT_INCLUDE_DIR}
+	${OPENGL_INCLUDE_PATH}
+)
+
+link_libraries (
+	piglitutil_${piglit_target_api}
+	${OPENGL_gl_LIBRARY}
+	${OPENGL_glu_LIBRARY}
+)
+
+piglit_add_executable (arb_gpu_shader5-invocations_count_too_large invocations_count_too_large.c)
diff --git a/tests/spec/arb_gpu_shader5/compiler/CMakeLists.txt b/tests/spec/arb_gpu_shader5/compiler/CMakeLists.txt
new file mode 100644
index 0000000..4a012b9
--- /dev/null
+++ b/tests/spec/arb_gpu_shader5/compiler/CMakeLists.txt
@@ -0,0 +1 @@
+piglit_include_target_api()
\ No newline at end of file
diff --git a/tests/spec/arb_gpu_shader5/compiler/invocations_count_too_large.c b/tests/spec/arb_gpu_shader5/compiler/invocations_count_too_large.c
new file mode 100644
index 0000000..5750807
--- /dev/null
+++ b/tests/spec/arb_gpu_shader5/compiler/invocations_count_too_large.c
@@ -0,0 +1,119 @@
+/*
+ * Copyright (c) 2014 Intel Corporation
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a
+ * copy of this software and associated documentation files (the "Software"),
+ * to deal in the Software without restriction, including without limitation
+ * the rights to use, copy, modify, merge, publish, distribute, sublicense,
+ * and/or sell copies of the Software, and to permit persons to whom the
+ * Software is furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice (including the next
+ * paragraph) shall be included in all copies or substantial portions of the
+ * Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
+ * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
+ * DEALINGS IN THE SOFTWARE.
+ */
+
+/** \file
+ *
+ * Test that exceeding the implementation's maximum invocations
+ * value (GL_MAX_GEOMETRY_SHADER_INVOCATIONS) results in a compile
+ * error.
+ *
+ * From the ARB_gpu_shader5 specification:
+ *
+ *     If a shader specifies an invocation count greater than
+ *     the implementation-dependent maximum, it will fail to
+ *     compile.
+ *
+ */
+
+#include "piglit-util-gl-common.h"
+
+PIGLIT_GL_TEST_CONFIG_BEGIN
+
+	config.supports_gl_compat_version = 32;
+	config.supports_gl_core_version = 32;
+
+PIGLIT_GL_TEST_CONFIG_END
+
+
+enum piglit_result
+piglit_display(void)
+{
+	/* UNREACHED */
+	return PIGLIT_FAIL;
+}
+
+
+static const char *gs_template =
+	"#version 150\n"
+	"#extension GL_ARB_gpu_shader5: enable\n"
+	"\n"
+	"layout(points, invocations = %d) in;\n"
+	"\n"
+	"void main()\n"
+	"{\n"
+	"}\n";
+
+
+static bool
+test_invocations_size(GLint size, bool expect_ok)
+{
+	char *shader_text;
+	GLint shader;
+	GLint ok;
+
+	printf("Invocation count of %d should %s: ", size,
+	       expect_ok ? "compile successfully" : "produce a compile error");
+
+	asprintf(&shader_text, gs_template, size);
+	shader = glCreateShader(GL_GEOMETRY_SHADER);
+	glShaderSource(shader, 1, (const GLchar **) &shader_text, NULL);
+	glCompileShader(shader);
+	glGetShaderiv(shader, GL_COMPILE_STATUS, &ok);
+	if (!piglit_check_gl_error(GL_NO_ERROR)) {
+		/* Details of the error have already been printed. */
+		printf("GL Error occurred.\n");
+		return false;
+	}
+	if (ok)
+		printf("Successful compile.\n");
+	else
+		printf("Compile error.\n");
+	return ok == expect_ok;
+}
+
+
+void
+piglit_init(int argc, char **argv)
+{
+	GLint max_invocations;
+	int i;
+	bool pass = true;
+
+	piglit_require_extension("GL_ARB_gpu_shader5");
+
+	glGetIntegerv(GL_MAX_GEOMETRY_SHADER_INVOCATIONS,
+		      &max_invocations);
+
+	if (!piglit_check_gl_error(GL_NO_ERROR))
+		piglit_report_result(PIGLIT_FAIL);
+
+	for (i = 1; i <= max_invocations; i++) {
+		/* Test that this size is allowed. */
+		pass = test_invocations_size(i, true) && pass;
+	}
+
+	/* Test that a count 1 above the max causes a compilation failure. */
+	pass = test_invocations_size(max_invocations + 1, false) && pass;
+
+	piglit_report_result(pass ? PIGLIT_PASS : PIGLIT_FAIL);
+}
-- 
1.8.5.3



More information about the Piglit mailing list