[Piglit] [PATCH] core: don't try to resolve the real path of the file

Dylan Baker baker.dylan.c at gmail.com
Sat Feb 8 04:08:13 CET 2014


On Friday, February 07, 2014 09:42:05 PM Ilia Mirkin wrote:
> This makes it possible to run the summary on e.g. compressed files or
> otherwise piped in with the <( ... ) shell construct.
> 
> There should be no difference between open() on a path before and after
> the realpath call.
> 
> Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu>
> ---
>  framework/core.py | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/framework/core.py b/framework/core.py
> index 45eea12..6a122f5 100644
> --- a/framework/core.py
> +++ b/framework/core.py
> @@ -647,8 +647,6 @@ def load_results(filename):
>      "main"
> 
>      """
> -    filename = os.path.realpath(filename)
> -
>      try:
>          with open(filename, 'r') as resultsfile:
>              testrun = TestrunResult(resultsfile)

I know that some people install piglit and add it's programs to their $PATH, 
is this going to break any of those use cases? It didn't seem to when I tested 
it, but some of those people might want to weigh in.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20140207/8b9bfbdf/attachment.pgp>


More information about the Piglit mailing list