[Piglit] [PATCH] core: don't try to resolve the real path of the file

[Ilia Mirkin]

On Mon, Feb 10, 2014 at 8:02 PM, Ken Phillis Jr <kphillisjr at gmail.com> wrote:
> I would suggest testing this a little bit more carefully. I know that
> I specifically ran into problems with this because someone may be
> running piglit in a situation where the user does not have write
> permissions for the piglit install path. This is a common practice for
> when users compile the program once and run the program across
> multiple systems over a network.

I may be showing signs of idiocy here, but... I don't at all
understand what you're saying. Could you elaborate as to the specific
example you have in mind where open(filename) differs from
open(os.path.realpath(filename))? The example that I have is where
"filename" is a fake symlink generated by the shell (or kernel, not
sure), and dereferencing it is harmful. That's why I've removed the
symlink dereference. In any other instance, open() would just follow
the symlink just like realpath would...

  -ilia