[Piglit] [PATCH 5/9] glx: Convert tests to using epoxy for GLX function pointer management.

Eric Anholt eric at anholt.net
Tue Feb 11 00:08:40 PST 2014


Ian Romanick <idr at freedesktop.org> writes:

> How does epoxy handle GetProcAddress returning NULL?
> tests/spec/glx_arb_create_context/indirect-es2-profile.c *really* wants
> to know if it got NULL for a function pointer.  There are a couple other
> tests that check for NULL to fail a test, but I'm less concerened about
> those.

It does just call right down.  I had assumed that this was just somebody
typing code out without thinking about how glx would always return a
non-null pointer.  I guess GLX doesn't specify the non-NULL behavior we
have, but it feels weird to be really careful about this one function
when we aren't about any others.

I could just drop the changes to the file if you want.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 818 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20140211/37793aba/attachment.pgp>


More information about the Piglit mailing list