[Piglit] [PATCH] gtest: Fix bug introduced in 90a256411

Ilia Mirkin imirkin at alum.mit.edu
Thu Feb 13 11:42:32 PST 2014


On Thu, Feb 13, 2014 at 1:59 PM, Dylan Baker <baker.dylan.c at gmail.com> wrote:
> In the mentioned commit the signature of Test.interpretResult was
> changed from (self, out, returncode, results, dmesg) to (self, out,
> returncode, results), however, this was not applied to GTest, which
> retained the dmesg argument.
>
> This patch fixes that bug.
>
> Signed-off-by: Dylan Baker <baker.dylan.c at gmail.com>

Reviewed-by: Ilia Mirkin <imirkin at alum.mit.edu>

>
> ---
>  framework/gtest.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/framework/gtest.py b/framework/gtest.py
> index 7b474f3..00ed6db 100644
> --- a/framework/gtest.py
> +++ b/framework/gtest.py
> @@ -29,7 +29,7 @@ import re
>  from framework.exectest import ExecTest
>
>  class GTest(ExecTest):
> -    def interpretResult(self, out, returncode, results, dmesg):
> +    def interpretResult(self, out, returncode, results):
>          # Since gtests can have several subtets, if any of the subtests fail
>          # then we need to report fail.
>          if len(re.findall('FAILED', out, re.MULTILINE)) > 0:
> --
> 1.8.5.4
>
> _______________________________________________
> Piglit mailing list
> Piglit at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/piglit


More information about the Piglit mailing list