[Piglit] [PATCH 1/2] glx_oml_sync_control: report FAIL if glXGetMscRateOML returns an error

[Daniel Kurtz]

On Tue, Feb 11, 2014 at 11:05 AM, Daniel Kurtz <djkurtz at chromium.org> wrote:
> On Tue, Feb 11, 2014 at 11:02 AM, Ian Romanick <idr at freedesktop.org> wrote:
>> On 02/05/2014 10:30 PM, Daniel Kurtz wrote:
>>> The glx_oml_sync_control does not parse parameters.  In particular, it
>>> does not parse the "-auto" flag to set piglit_automatic.
>>>
>>> So, when we return FAIL from draw(), it returns to the
>>> piglit_glx_event_loop, which just continues to spin waiting for events.
>>> Instead, just report the FAIL result, which quits the program.
>>>
>>> Signed-off-by: Daniel Kurtz <djkurtz at chromium.org>
>>
>> Oops.
>>
>> Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>
>>
>> Also, if only one person has ever edited (or mostly edited) a file, you
>> should CC that person on the patch.  That way they're more likely to
>> notice and send a R-b. :)

Ian,
Thanks for the review.
I don't have commit access, so, can someone please push this patch.

-Dan

>
> OK, thanks for the reviews and advice.
> Makes one appreciate the kernel's "get_maintainer.pl" :-).
>
>>
>>> ---
>>>  tests/spec/glx_oml_sync_control/getmscrate.c | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/tests/spec/glx_oml_sync_control/getmscrate.c b/tests/spec/glx_oml_sync_control/getmscrate.c
>>> index 9f0a43b..c18ea49 100644
>>> --- a/tests/spec/glx_oml_sync_control/getmscrate.c
>>> +++ b/tests/spec/glx_oml_sync_control/getmscrate.c
>>> @@ -41,7 +41,7 @@ draw(Display *dpy)
>>>
>>>       if (!glXGetMscRateOML(dpy, win, &numerator, &denominator)) {
>>>               printf("glXGetMscRateOML returned failure.\n");
>>> -             return PIGLIT_FAIL;
>>> +             piglit_report_result(PIGLIT_FAIL);
>>>       }
>>>
>>>       if (numerator == 0xDEADBEEF) {
>>>
>>