[Piglit] [PATCH 4/4] log: add verbose logger

[Dylan Baker]

On Monday, February 17, 2014 03:43:19 PM Ilia Mirkin wrote:
> On Mon, Feb 17, 2014 at 2:45 PM, Dylan Baker <baker.dylan.c at gmail.com> 
wrote:
> > diff --git a/piglit-resume.py b/piglit-resume.py
> > index 7b82420..5d41b9a 100755
> > --- a/piglit-resume.py
> > +++ b/piglit-resume.py
> > @@ -31,6 +31,10 @@ import framework.core as core
> > 
> >  def main():
> >      parser = argparse.ArgumentParser()
> > 
> > +    parser.add_argument("-v", "--verbose",
> > +                        action="store_true",
> > +                        help="Produce a line of output for each test
> > before " +                             "and after it runs")
> > 
> >      parser.add_argument("results_path",
> >      
> >                          type=path.realpath,
> >                          metavar="<Results Path>",
> > 
> > @@ -44,6 +48,10 @@ def main():
> >                             execute=results.options['execute'],
> >                             valgrind=results.options['valgrind'],
> >                             dmesg=results.options['dmesg'])
> > 
> > +
> > +    # Verbosity isn't a useful environment setting, and the user should
> > be able +    # to set it on their own.
> > +    env.verbose = results.options['verbose']
> 
> I'm not sure what your comment is referring to... As far as I can see,
> the -v to piglit-resume.py isn't actually used, since you use
> result.options['verbose']. However I would argue that the expectation
> is that piglit-resume.py should work in exactly the same way as the
> piglit run that it's resuming, including the verbose setting.
> 
> >      # Change working directory to the piglit directory
> >      os.chdir(path.dirname(path.realpath(sys.argv[0])))

I could go either way with it. I mean, it's not like concurrency or something 
like that which could alter the result of the test, but like I said, it 
doesn't matter much to me so I'll make that change.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20140217/174a6269/attachment-0001.pgp>