[Piglit] [PATCH] packed_depth_stencil: add a glGetTexImage test

[Eric Anholt]

Brian Paul <brianp at vmware.com> writes:
> +void
> +piglit_init(int argc, char **argv)
> +{
> +	bool pass;
> +
> +	if (piglit_get_gl_version() < 30
> +	    && !(piglit_is_extension_supported("GL_EXT_packed_depth_stencil") &&
> +		 piglit_is_extension_supported("GL_ARB_framebuffer_object"))) {
> +		printf("OpenGL 3.0 or GL_EXT_packed_depth_stencil + "
> +		       "GL_ARB_framebuffer_object is required.\n");
> +		piglit_report_result(PIGLIT_SKIP);
> +	}

I'm confused what ARB_fbo has to do with the test.  Isn't this test just
using EXT_packed_depth_stencil?

> +
> +	pass = test_z24_s8();
> +
> +	if (piglit_get_gl_version() >= 30 ||
> +	    piglit_is_extension_supported("GL_NV_depth_buffer_float")) {
> +		pass = test_z32_s8() && pass;
> +	}
> +
> +	piglit_report_result(pass ? PIGLIT_PASS : PIGLIT_FAIL);
> +}

Checking for NV_depth_buffer_float seems weird when we only advertise
GL_ARB_depth_buffer_float.

Other than these two comments,

Reviewed-by: Eric Anholt <eric at anholt.net>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 818 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20140227/c2466a08/attachment.pgp>