[Piglit] [PATCH 6/7] framework/tests/status_tests.py: remove equivalency tests

Dylan Baker baker.dylan.c at gmail.com
Fri Feb 28 15:43:02 PST 2014


These tests are not actually relevant, they were for testing the
definition of a docstring that was incorrect. That docstring was
updated, but the corresponding tests where not completely removed, which
means these tests ended up testing pass == pass, skip == skip, etc. Not
very useful

Signed-off-by: Dylan Baker <baker.dylan.c at gmail.com>
---
 framework/tests/status_tests.py | 14 --------------
 1 file changed, 14 deletions(-)

diff --git a/framework/tests/status_tests.py b/framework/tests/status_tests.py
index 0ecb522..7402638 100644
--- a/framework/tests/status_tests.py
+++ b/framework/tests/status_tests.py
@@ -79,13 +79,6 @@ def is_fix(x, y):
     assert status.status_lookup(x) > status.status_lookup(y)
 
 
-def is_equivalent(x, y):
-    # Test if status is equivalent. Note that this does not mean 'same', two
-    # statuses could be equivalent in terms of fixes and regressions, but that
-    # doesn't require that they are the same status
-    assert status.status_lookup(x) == status.status_lookup(y)
-
-
 def is_not_equivalent(x, y):
     # Test that status is not equivalent. 
     assert status.status_lookup(x) != status.status_lookup(y)
@@ -103,13 +96,6 @@ def test_is_fix():
         yield is_fix, x, y
 
 
-def test_is_equivalent():
-    # test the assertion that NotRun, Pass and Skip should be considered
-    # equivalent for regression testing.
-    for x, y in itertools.izip(STATUSES, STATUSES):
-        yield is_equivalent, x, y
-
-
 def test_is_change():
     for x, y in itertools.permutations(STATUSES, 2):
         yield is_not_equivalent, x, y
-- 
1.9.0



More information about the Piglit mailing list