[Piglit] [PATCH 04/12] tests/all.py: load glean glsl, frag, and vert tests internally

[Kenneth Graunke]

On 12/23/2013 04:51 PM, Dylan Baker wrote:
> This patch converts the glesn glsl1, fragPrgo1, and vertProg1 tests from
> external files that are called by execfile into lists of arguements, and
> uses a loop to add the tests.
> 
> This removes test files that are not in fact loadable test files, and
> lack a TestProfile instance, which means they will not be importable.
> 
> Signed-off-by: Dylan Baker <baker.dylan.c at gmail.com>
> ---
>  tests/all.tests             | 394 ++++++++++++++++++++++++++++++++++++++++----
>  tests/glean-fragProg1.tests |  52 ------
>  tests/glean-glsl1.tests     | 255 ----------------------------
>  tests/glean-vertProg1.tests |  42 -----
>  4 files changed, 363 insertions(+), 380 deletions(-)
>  delete mode 100644 tests/glean-fragProg1.tests
>  delete mode 100644 tests/glean-glsl1.tests
>  delete mode 100644 tests/glean-vertProg1.tests
> 
> diff --git a/tests/all.tests b/tests/all.tests
> index 38c0f5d..1cd3c79 100644
> --- a/tests/all.tests
> +++ b/tests/all.tests
> @@ -15,21 +15,16 @@ from framework.gleantest import GleanTest
>  from framework.glsl_parser_test import GLSLParserTest, add_glsl_parser_test, import_glsl_parser_tests
>  from framework.shader_test import add_shader_test_dir
>  
> -# Blacklisted tests are removed from the test profile.
> -blacklist = [
> -	]
> -

Blacklisting changes look unrelated.  I'm all for removing it...just saying.

[snip]

> +glean_glsl1_tests = ['Directly set fragment color',

Could just call this glean_glsl_tests if you prefer.  Don't care either way.

[snip]

> +glean_frag_tests = ['ABS test',

Could we please call this glean_fp_tests or glean_fragprog_tests?

[snip]

> +glean_vert_tests = ['ABS test',

Likewise, glean_vp_tests or glean_vertprog_tests...