[Piglit] [PATCH 8/8] egl_khr_create_context: Add valid-flag-debug tests to GLES CMakeLists

[Matt Turner]

On Fri, Jan 10, 2014 at 10:30 AM, Chad Versace
<chad.versace at linux.intel.com> wrote:
> On Tue, Jan 07, 2014 at 12:02:43AM +0800, Daniel Kurtz wrote:
>> Add these gles specific tests to CMakelists so they will be built when
>> targeting GLES.
>>
>> Signed-off-by: Daniel Kurtz <djkurtz at chromium.org>
>> ---
>>  tests/egl/spec/egl_khr_create_context/CMakeLists.gles2.txt | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/tests/egl/spec/egl_khr_create_context/CMakeLists.gles2.txt b/tests/egl/spec/egl_khr_create_context/CMakeLists.gles2.txt
>> index dde8960..c629888 100644
>> --- a/tests/egl/spec/egl_khr_create_context/CMakeLists.gles2.txt
>> +++ b/tests/egl/spec/egl_khr_create_context/CMakeLists.gles2.txt
>> @@ -27,5 +27,6 @@ piglit_add_executable (egl-create-context-invalid-flag-gles invalid-flag-gles.c
>>  # Tests that use ES 1, ES 2, and Desktop GL.
>>  piglit_add_executable (egl-create-context-invalid-gl-version invalid-gl-version.c common.c)
>>  piglit_add_executable (egl-create-context-verify-gl-flavor verify-gl-flavor.c common.c)
>> +piglit_add_executable (egl-create-context-valid-flag-debug valid-flag-debug.c common.c)
>
> NAK
>
> This patch breaks the Piglit build. In CMake, it's illegal to for
> a target name to have multiple definitions. And
> egl-create-context-valid-flag-debug is already defined in
> CMakeLists.gl.txt.

Isn't this simply fixed by suffixing the executable name with -gles,
like we've done for most of the other tests in this directory?