[Piglit] [PATCH 7/8] OES_compressed_ETC1_RGB8_texture-basic: fix glCopyTexImage2D error check

Chad Versace chad.versace at linux.intel.com
Fri Jan 10 11:01:05 PST 2014


On Tue, Jan 07, 2014 at 12:02:42AM +0800, Daniel Kurtz wrote:
> According to OpenGL ES 1.1 [0] and  OpenGL ES 2.0 [1], for
> glCopyTexImage2D:
> 
> GL_INVALID_ENUM is generated if internalformat is not an accepted constant.
> 
> [0] http://www.khronos.org/opengles/sdk/1.1/docs/man/glCopyTexImage2D.xml
> [1] http://www.khronos.org/opengles/sdk/docs/man/xhtml/glCopyTexImage2D.xml
> 
> Note: This is *different* than OpenGL [2] and OpenGL ES 3.0 [3], which
> both specify:
> GL_INVALID_VALUE is generated if internalformat is not an accepted format.
> 
> [2] http://www.opengl.org/sdk/docs/man/xhtml/glCopyTexImage2D.xml
> [3] http://www.khronos.org/opengles/sdk/docs/man3/xhtml/glCopyTexImage2D.xml
> 
> Signed-off-by: Daniel Kurtz <djkurtz at chromium.org>
> ---
>  .../oes_compressed_etc1_rgb8_texture-basic.c                          | 4 ++++
>  1 file changed, 4 insertions(+)

Looks good to me.
Reviewed-by: Chad Versace <chad.versace at linux.intel.com>


More information about the Piglit mailing list