[Piglit] [PATCH] tests/quick.py: Ensure glean receives the --quick parameter.

Dylan Baker baker.dylan.c at gmail.com
Tue Jan 14 13:31:49 PST 2014


This is fine, for a quick fix, you have my r-b to go ahead and push it. It's 
pretty fragile, and I have an idea for a more robust fix, and I'll send out 
that patch/series soon.

On Tuesday, January 14, 2014 05:07:51 PM jfonseca at vmware.com wrote:
> From: José Fonseca <jfonseca at vmware.com>
> 
> Which was lost as result of commit 5a12f3b9f0d6d93da1ac7a72c9806b1a831a1744.
> ---
>  tests/quick.py | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/quick.py b/tests/quick.py
> index 939aded..d603265 100644
> --- a/tests/quick.py
> +++ b/tests/quick.py
> @@ -1,11 +1,16 @@
>  # -*- coding: utf-8 -*-
> 
> +#
> +# XXX: These lines must be the first statements for the
> GleanTest.globalParams +# to be effective.  Do NOT add any import anything
> before.
> +#
>  from framework.gleantest import GleanTest
> +GleanTest.globalParams += ["--quick"]
> +
>  from tests.all import profile
> 
>  __all__ = ['profile']
> 
> -GleanTest.globalParams += ["--quick"]
> 
>  # These take too long
>  del profile.tests['shaders']['glsl-fs-inline-explosion']
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20140114/b08a5265/attachment.pgp>


More information about the Piglit mailing list