[Piglit] [PATCH V2 0/9] ARB_arrays_of_arrays compile tests

Ian Romanick idr at freedesktop.org
Thu Jan 16 09:57:38 PST 2014


On 01/14/2014 12:19 AM, Timothy Arceri wrote:
> V2 includes some additional tests and all previous fixes

I've skimmed the first two patches, and they look good so far.  Have you
been able to run these on any implementations (other than the one you're
writing) of this extension?  It would be really good if we could include
pass / fail results for other implementations in the commit messages.

> Timothy Arceri (9):
>   tests/spec: ARB_arrays_of_arrays initializer and constructor tests

Usually we'd do the tag for these tests as "arb_arrays_of_arrays: ".
That's a bit shorter too.

>   tests/spec: ARB_arrays_of_arrays function parameter and comparision
>     tests
>   tests/spec: ARB_arrays_of_arrays input and output tests
>   tests/spec: ARB_arrays_of_arrays interface and struct tests
>   tests/spec: ARB_arrays_of_arrays length and bounds tests
>   tests/spec: ARB_arrays_of_arrays redeclaration and subroutine tests
>   tests/spec: ARB_arrays_of_arrays uniform tests
>   tests/spec: ARB_arrays_of_arrays assignment tests
>   tests/spec: ARB_arrays_of_arrays builtin test
> 
>  tests/all.tests                                    |    7 +++
>  .../arrays-of-struct-with-field-arrays.vert        |   29 ++++++++++++
>  .../compiler/assigment-invalid-implicit-sized.vert |   28 ++++++++++++
>  .../compiler/assignment-1d-to-3d.vert              |   18 ++++++++
>  .../compiler/assignment-2d-to-3d-from-3d.vert      |   18 ++++++++
>  .../compiler/assignment-2d-to-3d.vert              |   18 ++++++++
>  .../compiler/assignment-array-array-var-array.vert |   16 +++++++
>  .../compiler/constructor-array-array-var.vert      |   17 +++++++
>  .../compiler/constructor-array-var-array.vert      |   17 +++++++
>  .../constructor-arrays-of-arrays-same-size.vert    |   24 ++++++++++
>  .../compiler/constructor-invalid-assignment.vert   |   17 +++++++
>  .../constructor-invalid-dimensions-mismatch.vert   |   20 ++++++++
>  .../constructor-invalid-element-to-big.vert        |   17 +++++++
>  .../compiler/constructor-invalid-type.vert         |   17 +++++++
>  .../compiler/constructor-invalid.vert              |   17 +++++++
>  .../compiler/constructor-invalid2.vert             |   16 +++++++
>  .../compiler/constructor-three-dimensions.vert     |   20 ++++++++
>  .../compiler/constructor-unsized.vert              |   17 +++++++
>  .../compiler/constructor-var-array-array.vert      |   17 +++++++
>  .../compiler/equal-implicit-size.vert              |   28 ++++++++++++
>  .../compiler/equal-mismatched-size.vert            |   23 ++++++++++
>  .../spec/arb_arrays_of_arrays/compiler/equal.vert  |   23 ++++++++++
>  ...tion-parameter-declaration-array-array-var.vert |   19 ++++++++
>  ...tion-parameter-declaration-array-var-array.vert |   19 ++++++++
>  ...tion-parameter-declaration-var-array-array.vert |   19 ++++++++
>  ...ction-parameter-definition-array-array-var.vert |   22 +++++++++
>  ...ction-parameter-definition-array-var-array.vert |   22 +++++++++
>  ...ction-parameter-definition-var-array-array.vert |   22 +++++++++
>  .../compiler/function-parameter-unsized.vert       |   22 +++++++++
>  .../compiler/gl_TexCoord-invalid-multidim.vert     |   17 +++++++
>  .../compiler/initialization-invalid.vert           |   17 +++++++
>  .../compiler/initialization-invalid2.vert          |   19 ++++++++
>  .../compiler/initialization-invalid3.vert          |   19 ++++++++
>  .../compiler/initialization-invalid4.vert          |   19 ++++++++
>  .../compiler/initializer-array-array-var.vert      |   19 ++++++++
>  .../compiler/initializer-array-array-var2.vert     |   19 ++++++++
>  .../compiler/initializer-array-var-array.vert      |   19 ++++++++
>  .../compiler/initializer-array-var-array2.vert     |   19 ++++++++
>  ...alizer-dec-list-type-array-array-var1-var2.vert |   43 ++++++++++++++++++
>  ...-dec-list-type-array-var1-array-var2-array.vert |   47 +++++++++++++++++++
>  ...ist-type-var1-array-array-var2-array-array.vert |   43 ++++++++++++++++++
>  .../initializer-struct-field-array-array-var.vert  |   34 ++++++++++++++
>  .../initializer-struct-field-array-var-array.vert  |   34 ++++++++++++++
>  ...truct-field-dec-list-array-array-var1-var2.vert |   48 ++++++++++++++++++++
>  ...truct-field-dec-list-array-var1-array-var2.vert |   38 ++++++++++++++++
>  ...truct-field-dec-list-array-var1-var2-array.vert |   38 ++++++++++++++++
>  .../initializer-struct-field-var-array-array.vert  |   34 ++++++++++++++
>  .../compiler/initializer-three-dimensions.vert     |   22 +++++++++
>  .../compiler/initializer-three-dimensions2.vert    |   22 +++++++++
>  .../compiler/initializer-var-array-array.vert      |   19 ++++++++
>  .../compiler/initializer-var-array-array2.vert     |   19 ++++++++
>  .../compiler/input-array-array-var.vert            |   15 ++++++
>  .../compiler/input-array-var-array.vert            |   15 ++++++
>  .../compiler/input-var-array-array.vert            |   15 ++++++
>  .../compiler/interface-field-array-array-var.vert  |   18 ++++++++
>  .../compiler/interface-field-array-var-array.vert  |   18 ++++++++
>  ...ce-field-maxbounds-access-array-array-var .geom |   18 ++++++++
>  ...ace-field-maxbounds-access-array-var-array.geom |   18 ++++++++
>  ...ace-field-maxbounds-access-var-array-array.geom |   18 ++++++++
>  ...e-field-outofbounds-access-array-array-var.geom |   18 ++++++++
>  ...e-field-outofbounds-access-array-var-array.geom |   18 ++++++++
>  ...e-field-outofbounds-access-var-array-array.geom |   18 ++++++++
>  .../compiler/interface-field-var-array-array.vert  |   18 ++++++++
>  .../compiler/interface-maxbounds.vert              |   18 ++++++++
>  .../compiler/interface-outofbounds.vert            |   18 ++++++++
>  .../arb_arrays_of_arrays/compiler/interface.vert   |   18 ++++++++
>  .../compiler/length-array-array-var.vert           |   13 ++++++
>  .../compiler/length-array-var-array.vert           |   13 ++++++
>  .../compiler/length-var-array-array.vert           |   13 ++++++
>  .../compiler/maxbounds-access-array-array-var.vert |   15 ++++++
>  .../compiler/maxbounds-access-array-var-array.vert |   15 ++++++
>  .../compiler/maxbounds-access-var-array-array.vert |   15 ++++++
>  .../outofbounds-access-array-array-var.vert        |   15 ++++++
>  .../outofbounds-access-array-var-array.vert        |   15 ++++++
>  .../outofbounds-access-var-array-array.vert        |   15 ++++++
>  .../compiler/output-array-array-var.frag           |   17 +++++++
>  .../compiler/output-array-array-var.vert           |   19 ++++++++
>  .../compiler/output-array-var-array.frag           |   17 +++++++
>  .../compiler/output-array-var-array.vert           |   19 ++++++++
>  .../compiler/output-var-array-array.frag           |   17 +++++++
>  .../compiler/output-var-array-array.vert           |   19 ++++++++
>  .../compiler/redeclaration-initializer.vert        |   31 +++++++++++++
>  .../compiler/redeclaration-too-small.vert          |   29 ++++++++++++
>  .../compiler/redeclaration-too-small2.vert         |   23 ++++++++++
>  .../compiler/redeclaration.vert                    |   29 ++++++++++++
>  .../compiler/redeclaration2.vert                   |   29 ++++++++++++
>  .../compiler/structure-field-array-array-var.frag  |   19 ++++++++
>  .../compiler/structure-field-array-var-array.frag  |   19 ++++++++
>  .../compiler/structure-field-var-array-array.frag  |   19 ++++++++
>  .../arb_arrays_of_arrays/compiler/subroutine.vert  |   37 +++++++++++++++
>  .../compiler/uniform-array-array-var.vert          |   15 ++++++
>  .../compiler/uniform-array-var-array.vert          |   15 ++++++
>  .../compiler/uniform-unsized-array-array-var.vert  |   15 ++++++
>  .../compiler/uniform-unsized-array-var-array.vert  |   15 ++++++
>  .../uniform-unsized-invalid-array-array-var.vert   |   21 +++++++++
>  .../uniform-unsized-invalid-array-array-var2.vert  |   21 +++++++++
>  .../uniform-unsized-invalid-array-var-array.vert   |   21 +++++++++
>  .../uniform-unsized-invalid-array-var-array2.vert  |   21 +++++++++
>  .../uniform-unsized-invalid-var-array-array.vert   |   21 +++++++++
>  .../uniform-unsized-invalid-var-array-array2.vert  |   21 +++++++++
>  .../compiler/uniform-unsized-var-array-array.vert  |   15 ++++++
>  .../compiler/uniform-var-array-array.vert          |   15 ++++++
>  102 files changed, 2126 insertions(+)
>  create mode 100644 tests/spec/arb_arrays_of_arrays/compiler/arrays-of-struct-with-field-arrays.vert
>  create mode 100644 tests/spec/arb_arrays_of_arrays/compiler/assigment-invalid-implicit-sized.vert
>  create mode 100644 tests/spec/arb_arrays_of_arrays/compiler/assignment-1d-to-3d.vert
>  create mode 100644 tests/spec/arb_arrays_of_arrays/compiler/assignment-2d-to-3d-from-3d.vert
>  create mode 100644 tests/spec/arb_arrays_of_arrays/compiler/assignment-2d-to-3d.vert
>  create mode 100644 tests/spec/arb_arrays_of_arrays/compiler/assignment-array-array-var-array.vert
>  create mode 100644 tests/spec/arb_arrays_of_arrays/compiler/constructor-array-array-var.vert
>  create mode 100644 tests/spec/arb_arrays_of_arrays/compiler/constructor-array-var-array.vert
>  create mode 100644 tests/spec/arb_arrays_of_arrays/compiler/constructor-arrays-of-arrays-same-size.vert
>  create mode 100644 tests/spec/arb_arrays_of_arrays/compiler/constructor-invalid-assignment.vert
>  create mode 100644 tests/spec/arb_arrays_of_arrays/compiler/constructor-invalid-dimensions-mismatch.vert
>  create mode 100644 tests/spec/arb_arrays_of_arrays/compiler/constructor-invalid-element-to-big.vert
>  create mode 100644 tests/spec/arb_arrays_of_arrays/compiler/constructor-invalid-type.vert
>  create mode 100644 tests/spec/arb_arrays_of_arrays/compiler/constructor-invalid.vert
>  create mode 100644 tests/spec/arb_arrays_of_arrays/compiler/constructor-invalid2.vert
>  create mode 100644 tests/spec/arb_arrays_of_arrays/compiler/constructor-three-dimensions.vert
>  create mode 100644 tests/spec/arb_arrays_of_arrays/compiler/constructor-unsized.vert
>  create mode 100644 tests/spec/arb_arrays_of_arrays/compiler/constructor-var-array-array.vert
>  create mode 100644 tests/spec/arb_arrays_of_arrays/compiler/equal-implicit-size.vert
>  create mode 100644 tests/spec/arb_arrays_of_arrays/compiler/equal-mismatched-size.vert
>  create mode 100644 tests/spec/arb_arrays_of_arrays/compiler/equal.vert
>  create mode 100644 tests/spec/arb_arrays_of_arrays/compiler/function-parameter-declaration-array-array-var.vert
>  create mode 100644 tests/spec/arb_arrays_of_arrays/compiler/function-parameter-declaration-array-var-array.vert
>  create mode 100644 tests/spec/arb_arrays_of_arrays/compiler/function-parameter-declaration-var-array-array.vert
>  create mode 100644 tests/spec/arb_arrays_of_arrays/compiler/function-parameter-definition-array-array-var.vert
>  create mode 100644 tests/spec/arb_arrays_of_arrays/compiler/function-parameter-definition-array-var-array.vert
>  create mode 100644 tests/spec/arb_arrays_of_arrays/compiler/function-parameter-definition-var-array-array.vert
>  create mode 100644 tests/spec/arb_arrays_of_arrays/compiler/function-parameter-unsized.vert
>  create mode 100644 tests/spec/arb_arrays_of_arrays/compiler/gl_TexCoord-invalid-multidim.vert
>  create mode 100644 tests/spec/arb_arrays_of_arrays/compiler/initialization-invalid.vert
>  create mode 100644 tests/spec/arb_arrays_of_arrays/compiler/initialization-invalid2.vert
>  create mode 100644 tests/spec/arb_arrays_of_arrays/compiler/initialization-invalid3.vert
>  create mode 100644 tests/spec/arb_arrays_of_arrays/compiler/initialization-invalid4.vert
>  create mode 100644 tests/spec/arb_arrays_of_arrays/compiler/initializer-array-array-var.vert
>  create mode 100644 tests/spec/arb_arrays_of_arrays/compiler/initializer-array-array-var2.vert
>  create mode 100644 tests/spec/arb_arrays_of_arrays/compiler/initializer-array-var-array.vert
>  create mode 100644 tests/spec/arb_arrays_of_arrays/compiler/initializer-array-var-array2.vert
>  create mode 100644 tests/spec/arb_arrays_of_arrays/compiler/initializer-dec-list-type-array-array-var1-var2.vert
>  create mode 100644 tests/spec/arb_arrays_of_arrays/compiler/initializer-dec-list-type-array-var1-array-var2-array.vert
>  create mode 100644 tests/spec/arb_arrays_of_arrays/compiler/initializer-dec-list-type-var1-array-array-var2-array-array.vert
>  create mode 100644 tests/spec/arb_arrays_of_arrays/compiler/initializer-struct-field-array-array-var.vert
>  create mode 100644 tests/spec/arb_arrays_of_arrays/compiler/initializer-struct-field-array-var-array.vert
>  create mode 100644 tests/spec/arb_arrays_of_arrays/compiler/initializer-struct-field-dec-list-array-array-var1-var2.vert
>  create mode 100644 tests/spec/arb_arrays_of_arrays/compiler/initializer-struct-field-dec-list-array-var1-array-var2.vert
>  create mode 100644 tests/spec/arb_arrays_of_arrays/compiler/initializer-struct-field-dec-list-array-var1-var2-array.vert
>  create mode 100644 tests/spec/arb_arrays_of_arrays/compiler/initializer-struct-field-var-array-array.vert
>  create mode 100644 tests/spec/arb_arrays_of_arrays/compiler/initializer-three-dimensions.vert
>  create mode 100644 tests/spec/arb_arrays_of_arrays/compiler/initializer-three-dimensions2.vert
>  create mode 100644 tests/spec/arb_arrays_of_arrays/compiler/initializer-var-array-array.vert
>  create mode 100644 tests/spec/arb_arrays_of_arrays/compiler/initializer-var-array-array2.vert
>  create mode 100644 tests/spec/arb_arrays_of_arrays/compiler/input-array-array-var.vert
>  create mode 100644 tests/spec/arb_arrays_of_arrays/compiler/input-array-var-array.vert
>  create mode 100644 tests/spec/arb_arrays_of_arrays/compiler/input-var-array-array.vert
>  create mode 100644 tests/spec/arb_arrays_of_arrays/compiler/interface-field-array-array-var.vert
>  create mode 100644 tests/spec/arb_arrays_of_arrays/compiler/interface-field-array-var-array.vert
>  create mode 100644 tests/spec/arb_arrays_of_arrays/compiler/interface-field-maxbounds-access-array-array-var .geom
>  create mode 100644 tests/spec/arb_arrays_of_arrays/compiler/interface-field-maxbounds-access-array-var-array.geom
>  create mode 100644 tests/spec/arb_arrays_of_arrays/compiler/interface-field-maxbounds-access-var-array-array.geom
>  create mode 100644 tests/spec/arb_arrays_of_arrays/compiler/interface-field-outofbounds-access-array-array-var.geom
>  create mode 100644 tests/spec/arb_arrays_of_arrays/compiler/interface-field-outofbounds-access-array-var-array.geom
>  create mode 100644 tests/spec/arb_arrays_of_arrays/compiler/interface-field-outofbounds-access-var-array-array.geom
>  create mode 100644 tests/spec/arb_arrays_of_arrays/compiler/interface-field-var-array-array.vert
>  create mode 100644 tests/spec/arb_arrays_of_arrays/compiler/interface-maxbounds.vert
>  create mode 100644 tests/spec/arb_arrays_of_arrays/compiler/interface-outofbounds.vert
>  create mode 100644 tests/spec/arb_arrays_of_arrays/compiler/interface.vert
>  create mode 100644 tests/spec/arb_arrays_of_arrays/compiler/length-array-array-var.vert
>  create mode 100644 tests/spec/arb_arrays_of_arrays/compiler/length-array-var-array.vert
>  create mode 100644 tests/spec/arb_arrays_of_arrays/compiler/length-var-array-array.vert
>  create mode 100644 tests/spec/arb_arrays_of_arrays/compiler/maxbounds-access-array-array-var.vert
>  create mode 100644 tests/spec/arb_arrays_of_arrays/compiler/maxbounds-access-array-var-array.vert
>  create mode 100644 tests/spec/arb_arrays_of_arrays/compiler/maxbounds-access-var-array-array.vert
>  create mode 100644 tests/spec/arb_arrays_of_arrays/compiler/outofbounds-access-array-array-var.vert
>  create mode 100644 tests/spec/arb_arrays_of_arrays/compiler/outofbounds-access-array-var-array.vert
>  create mode 100644 tests/spec/arb_arrays_of_arrays/compiler/outofbounds-access-var-array-array.vert
>  create mode 100644 tests/spec/arb_arrays_of_arrays/compiler/output-array-array-var.frag
>  create mode 100644 tests/spec/arb_arrays_of_arrays/compiler/output-array-array-var.vert
>  create mode 100644 tests/spec/arb_arrays_of_arrays/compiler/output-array-var-array.frag
>  create mode 100644 tests/spec/arb_arrays_of_arrays/compiler/output-array-var-array.vert
>  create mode 100644 tests/spec/arb_arrays_of_arrays/compiler/output-var-array-array.frag
>  create mode 100644 tests/spec/arb_arrays_of_arrays/compiler/output-var-array-array.vert
>  create mode 100644 tests/spec/arb_arrays_of_arrays/compiler/redeclaration-initializer.vert
>  create mode 100644 tests/spec/arb_arrays_of_arrays/compiler/redeclaration-too-small.vert
>  create mode 100644 tests/spec/arb_arrays_of_arrays/compiler/redeclaration-too-small2.vert
>  create mode 100644 tests/spec/arb_arrays_of_arrays/compiler/redeclaration.vert
>  create mode 100644 tests/spec/arb_arrays_of_arrays/compiler/redeclaration2.vert
>  create mode 100644 tests/spec/arb_arrays_of_arrays/compiler/structure-field-array-array-var.frag
>  create mode 100644 tests/spec/arb_arrays_of_arrays/compiler/structure-field-array-var-array.frag
>  create mode 100644 tests/spec/arb_arrays_of_arrays/compiler/structure-field-var-array-array.frag
>  create mode 100644 tests/spec/arb_arrays_of_arrays/compiler/subroutine.vert
>  create mode 100644 tests/spec/arb_arrays_of_arrays/compiler/uniform-array-array-var.vert
>  create mode 100644 tests/spec/arb_arrays_of_arrays/compiler/uniform-array-var-array.vert
>  create mode 100644 tests/spec/arb_arrays_of_arrays/compiler/uniform-unsized-array-array-var.vert
>  create mode 100644 tests/spec/arb_arrays_of_arrays/compiler/uniform-unsized-array-var-array.vert
>  create mode 100644 tests/spec/arb_arrays_of_arrays/compiler/uniform-unsized-invalid-array-array-var.vert
>  create mode 100644 tests/spec/arb_arrays_of_arrays/compiler/uniform-unsized-invalid-array-array-var2.vert
>  create mode 100644 tests/spec/arb_arrays_of_arrays/compiler/uniform-unsized-invalid-array-var-array.vert
>  create mode 100644 tests/spec/arb_arrays_of_arrays/compiler/uniform-unsized-invalid-array-var-array2.vert
>  create mode 100644 tests/spec/arb_arrays_of_arrays/compiler/uniform-unsized-invalid-var-array-array.vert
>  create mode 100644 tests/spec/arb_arrays_of_arrays/compiler/uniform-unsized-invalid-var-array-array2.vert
>  create mode 100644 tests/spec/arb_arrays_of_arrays/compiler/uniform-unsized-var-array-array.vert
>  create mode 100644 tests/spec/arb_arrays_of_arrays/compiler/uniform-var-array-array.vert



More information about the Piglit mailing list