[Piglit] [PATCH] gl-3.2-depth-tex-sampling: Check piglit_check_gl_error return value.

Brian Paul brianp at vmware.com
Mon Jan 20 06:22:17 PST 2014


On 01/18/2014 02:50 PM, Vinson Lee wrote:
> Fixes "Unchecked return value" defect reported by Coverity.
>
> Signed-off-by: Vinson Lee <vlee at freedesktop.org>
> ---
>   tests/spec/gl-3.2/depth-tex-sampling.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/spec/gl-3.2/depth-tex-sampling.c b/tests/spec/gl-3.2/depth-tex-sampling.c
> index 32079c1..a7def6c 100644
> --- a/tests/spec/gl-3.2/depth-tex-sampling.c
> +++ b/tests/spec/gl-3.2/depth-tex-sampling.c
> @@ -199,7 +199,7 @@ piglit_display(void)
>
>   	piglit_present_results();
>
> -	piglit_check_gl_error(GL_NO_ERROR);
> +	pass = piglit_check_gl_error(GL_NO_ERROR) && pass;
>
>   	return pass ? PIGLIT_PASS : PIGLIT_FAIL;
>   }
>

For all six patches:  Reviewed-by: Brian Paul <brianp at vmware.com>



More information about the Piglit mailing list