[Piglit] [PATCH 2/3] framework: Add support for a test timeout

Matt Turner mattst88 at gmail.com
Mon Jan 20 11:49:20 PST 2014


On Tue, Nov 12, 2013 at 2:36 AM, Daniel Vetter <daniel.vetter at ffwll.ch> wrote:
> i-g-t tests can take a long time, and for a bunch of reasons (bad
> tuning on disparate set of platforms, stuck in the kernel which often
> can be recovered by interrupting with a signal, ...) that sometimes
> extends to a good approximation of forever.
>
> Hence this adds a per-test timeout value and a bit of infrastructure
> to adjust the results. Test results adjusting is done after calling
> interpretResult so that we don't have to replicate this all over the
> place. This might need to be adjusted for the piglit-native subtest
> stuff, but otoh igt is a bit special with it's crazy long-running
> tests. So I think we can fix this once it's actually needed.
>
> The default timeout is None, so this is purely opt-in.
>
> Note on the implementation: SIG_ALARM doesn't exists on Windows and
> stackoverflow overwhelmingly recommended to go with this thread-based
> approach here. But only tested on my Linux box here.
> ---

This patch seems to tickle a python bug that results in consistently
corrupted json results files.

Let's revert this. It's been two months. :(


More information about the Piglit mailing list