[Piglit] [PATCH 1/5] tests/gleantest_tests.py: move into tests folder

Dylan Baker baker.dylan.c at gmail.com
Thu Jan 23 10:25:07 PST 2014


This was added into framework, which fits nose's recommendation for
where to put test files (name them <module>_tests.py and place them in
the same directory. The problem is that piglit is a test suite itself,
meaning it has numerous modules named in the form <foo>_tests(s).py.
Nose assumes those files contain python unittests and attempts to run
them, and generates a number of false positive failures.

This leaves two options:
1) add __test__ = false to each piglit test class module
2) move all of the tests to a subfolder and run nose out of that folder.

Option 2 seemed better to me, since IMHO putting metadata in code files
is annoying.

Signed-off-by: Dylan Baker <baker.dylan.c at gmail.com>
---
 framework/{ => tests}/gleantest_tests.py | 0
 1 file changed, 0 insertions(+), 0 deletions(-)
 rename framework/{ => tests}/gleantest_tests.py (100%)

diff --git a/framework/gleantest_tests.py b/framework/tests/gleantest_tests.py
similarity index 100%
rename from framework/gleantest_tests.py
rename to framework/tests/gleantest_tests.py
-- 
1.8.5.3



More information about the Piglit mailing list