[Piglit] [PATCH 00/10] Allow building and running EGL+GLES tests without GLX

[Brent Austin]

On Sun, Jan 19, 2014 at 12:47 PM, Chad Versace
<chad.versace at linux.intel.com> wrote:
> On Wed, Jan 15, 2014 at 07:09:55PM +0800, Daniel Kurtz wrote:

[snip]

>> I'm really not sure about that last patch.  It works for my situation, since
>> my libEGL.so, libGLESv2.so and libGLESv1_CM.so are all exactly the same library
>> (they are all just symlinks to vendor .so).  But I don't think it will work in
>> the general case where these are really separate libraries, with potentially
>> conflicting core functions.
>
> I'm also uncertain about your last patch.
>
> Are you aware of any shipping EGL implementation that we wish to run
> Piglit on in the short-term and where eglGetProcAddress to fails to work
> for core functions?  Mesa doesn't suffer from that problem; it behaves
> as if it supported EGL_KHR_get_all_proc_addresses even though it does
> not yet expose the extension string.
>
> If the problem is only theoretical, and Piglit will not encounter such
> an implementation in the short-term, then I propose we drop the dlsym
> patch. Otherwise, we need to design the patch to work reliably in the
> general case where distinct EGL, GL, and GLES 1-3 libraries are
> installed, which is the case for Mesa.
>

I'm pretty sure that eglGetProcAddress() does not work correctly for
core functions on Android.  For core functions, it will return a
non-NULL pointer to the wrong function.  This may have been fixed for
newer versions of Android, but it has definitely been a problem in the
past.

Brent