[Piglit] [PATCH] framework/core: Fix performance regression from e4c9a3621a

Dylan Baker baker.dylan.c at gmail.com
Thu Jan 30 09:49:26 PST 2014


There is a sort of corner case regression caused by this patch, if the
number of tests are less than 50 they are effectively always run
serially. This can have a pretty big performance impact, especially if
any of those tests takes a long time to run. Reducing this to 1 results
in a very slight performance reduction of very long runs (~2 seconds
difference on quick.tests), but the trade off for short runs is much
more significant.

Signed-off-by: Dylan Baker <baker.dylan.c at gmail.com>
---
 framework/core.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/framework/core.py b/framework/core.py
index a193a2d..a335033 100644
--- a/framework/core.py
+++ b/framework/core.py
@@ -547,7 +547,7 @@ class TestProfile:
         # The default value of pool is the number of virtual processor cores
         single = multiprocessing.dummy.Pool(1)
         multi = multiprocessing.dummy.Pool()
-        chunksize = 50
+        chunksize = 1
 
         if env.concurrent == "all":
             multi.imap(test, self.test_list.iteritems(), chunksize)
-- 
1.8.5.3



More information about the Piglit mailing list