[Piglit] [PATCH] Make getteximage-luminance less susceptible to rounding error

Jason Ekstrand jason at jlekstrand.net
Fri Jul 11 13:40:49 PDT 2014


In the readpixels_rgba_as_lum test, use three values which don't nicely
convert to unsigned bytes and then sum them and assume that we'll be very
close to the floatin-point sum.  If the implementation rounds down during
texture upload, the test used to fail.  This switches it to use the
pixman-standard tollerance of 3.0 / 255 which should be sufficient.

Signed-off-by: Jason Ekstrand <jason.ekstrand at intel.com>
---
 tests/texturing/getteximage-luminance.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/texturing/getteximage-luminance.c b/tests/texturing/getteximage-luminance.c
index 389c3a2..2561062 100644
--- a/tests/texturing/getteximage-luminance.c
+++ b/tests/texturing/getteximage-luminance.c
@@ -39,7 +39,7 @@ PIGLIT_GL_TEST_CONFIG_BEGIN
 PIGLIT_GL_TEST_CONFIG_END
 
 static const char *TestName = "getteximage-luminance";
-static float tolerance = 2.0 / 255.0;
+static float tolerance = 3.0 / 255.0;
 
 
 static bool
-- 
2.0.0



More information about the Piglit mailing list