[Piglit] [Patch v2 1/4] framework: allow loading a piglit.conf from more locations

Dylan Baker baker.dylan.c at gmail.com
Tue Jul 15 18:39:20 PDT 2014


On Tuesday, July 15, 2014 04:44:31 PM Jordan Justen wrote:
> On Tue, Jul 15, 2014 at 7:02 AM, Dylan Baker <baker.dylan.c at gmail.com> 
wrote:
> > [snip]
> > 
> >> > +        else:
> >> > +            if __debug__:
> >> > +                print('Warning: piglit.conf not found!\n'
> >> > +                      '(searching current dir, $HOME/.config, '
> >> > +                      '$XDG_CONFIG_HOME, and piglit source dir)',
> >> > +                      file=sys.stderr)
> >> 
> >> Did you mean to strip this debug warning? I don't think a warning
> >> message is needed if piglit.conf doesn't exist.
> >> 
> >> -Jordan
> > 
> > I had meant to leave it, I thought it was useful to have a warning that
> > piglit hadn't found a config file, but if it bothers people (I know that
> > Carl had also mentioned it annoyed him) I don't have a problem removing
> > it.
> Should I be concerned if piglit.conf is missing?
> 
> I suspect not, and therefore it doesn't seem like a warning is needed.
> 
> -Jordan

If you want to use an external suite then you do, and I'd like to move more 
options into the config, but we can remove it. Or you can run piglit with 
'python -O' which will make that and other debug options disapear.

Either way though.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20140715/7bc075d7/attachment.sig>


More information about the Piglit mailing list