[Piglit] [PATCH] framework: fix duplicated TEST_BIN_DIR for cygwin
brianp at vmware.com
Wed Jul 16 09:54:32 PDT 2014
On 07/16/2014 10:40 AM, Dylan Baker wrote:
> On Wednesday, July 16, 2014 10:31:45 AM Brian Paul wrote:
>> The GLSLParserTest, ShaderTest and GleanTest subclasses of the Test
>> class were prepending the TEST_BIN_DIR variable onto the executable
>> name (such as "glslparsertest", "shader_runner", and "glean"). But
>> the Test class itself also does that so we were prepending TEST_BIN_DIR
> That's not quite right, PiglitTest (not Test) prepends TEST_BIN_DIR to the
> first element of the command. It's an important distinction because GleanTest
> doesn't descend from PiglitTest, only GLSLParserTest and ShaderTest do.
> So, the change to GleanTest is incorrect (try running it, they'll all return
> skip). But the changes to GLSLParserTest and ShaderTest look fine. It might be
> worth adding an assert to the PiglitTest constructor for this; something like
> 'assert not self._command.startswith(TEST_BIN_DIR)'
Ah, right. New patch coming...
More information about the Piglit