[Piglit] [PATCH] max-texture-size: Really test GL_PROXY_TEXTURE_RECTANGLE

[Anuj Phogat]

On Mon, Jul 21, 2014 at 11:21 AM, Jon TURNEY
<jon.turney at dronecode.org.uk> wrote:
> Fix a typo so that GL_PROXY_TEXTURE_RECTANGLE test actually tests that.
>
> Signed-off-by: Jon TURNEY <jon.turney at dronecode.org.uk>
> ---
>  tests/texturing/max-texture-size.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/texturing/max-texture-size.c b/tests/texturing/max-texture-size.c
> index 8afa9ef..e9f5c6b 100644
> --- a/tests/texturing/max-texture-size.c
> +++ b/tests/texturing/max-texture-size.c
> @@ -195,8 +195,8 @@ test_proxy_texture_size(GLenum target, GLenum internalformat)
>                 break;
>
>         case GL_TEXTURE_RECTANGLE:
> -               glTexImage2D(target, 0, internalformat, maxSide,
> -                            maxSide, 0, GL_RGBA, GL_FLOAT, NULL);
> +               glTexImage2D(GL_PROXY_TEXTURE_RECTANGLE, 0, internalformat,
> +                            maxSide, maxSide, 0, GL_RGBA, GL_FLOAT, NULL);
>                 break;
It will be nice to define a proxyTarget variable here and get its value using
getProxyTarget(target). Then you can combine the cases for TEXTURE_2D,
TEXTURE_RECTANGLE and TEXTURE_CUBE_MAP together.
Whether you decide to use my suggestion or not, patch is:
Reviewed-by: Anuj Phogat <anuj.phogat at gmail.com>

>
>         case GL_TEXTURE_3D:
> --
> 1.8.5.5
>
> _______________________________________________
> Piglit mailing list
> Piglit at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/piglit