[Piglit] [PATCH v2 1/1] cl: Extend float to long conversion test

Tom Stellard tom at stellard.net
Fri Jul 25 10:10:42 PDT 2014


On Fri, Jul 25, 2014 at 09:49:08AM -0400, Jan Vesely wrote:
> On Tue, 2014-07-15 at 10:22 -0400, Tom Stellard wrote:
> > On Tue, Jul 15, 2014 at 09:03:18AM -0400, Jan Vesely wrote:
> > > a light poke
> > > 
> > > Tom, Matt,
> > > sorry I forgot to CC you, this piglit tests the conversions submitted
> > > last week.
> > > 
> > 
> > Reviewed-by: Tom Stellard <thomas.stellard at amd.com>
> 
> Thank you. Can you push it as well? I don't have commit access
> 

I just pushed this, thanks!

-Tom

> jan
> 
> > 
> > > thank you,
> > > Jan
> > > 
> > > On Tue, 2014-06-24 at 15:15 -0400, Jan Vesely wrote:
> > > > Fill in subtest name
> > > > v2: Add 2^63 as a test value
> > > > 
> > > > Signed-off-by: Jan Vesely <jan.vesely at rutgers.edu>
> > > > ---
> > > >  .../execute/builtin/convert/float-convert_long.cl  | 28 ++++++++++++++++++++--
> > > >  1 file changed, 26 insertions(+), 2 deletions(-)
> > > > 
> > > > diff --git a/tests/cl/program/execute/builtin/convert/float-convert_long.cl b/tests/cl/program/execute/builtin/convert/float-convert_long.cl
> > > > index 3d6930a..c8baa38 100644
> > > > --- a/tests/cl/program/execute/builtin/convert/float-convert_long.cl
> > > > +++ b/tests/cl/program/execute/builtin/convert/float-convert_long.cl
> > > > @@ -4,9 +4,10 @@ name: convert_long(float)
> > > >  dimensions: 1
> > > >  global_size: 1 1 1
> > > >  local_size: 1 1 1
> > > > -kernel_name: test
> > > >  
> > > >  [test]
> > > > +name: convert_long(float)
> > > > +kernel_name: test_long
> > > >  arg_out: 0 buffer long[8] 0 36864 -47104 41943040 -35651584 131 5000000000 -6000000000
> > > >  # These values were choosen to exercise all code paths in the generic
> > > >  # implementation of __fixsfdi in compiler-rt:
> > > > @@ -20,11 +21,34 @@ arg_in:  1 buffer float[8] 0x1.2p-5      \ # exp < 0
> > > >                             5000000000.0  \ # Positive value requiring more than 32-bits
> > > >                             -6000000000.0   # Negative value requiring more than 32-bits
> > > >  
> > > > +[test]
> > > > +name: convert_ulong(float)
> > > > +kernel_name: test_ulong
> > > > +arg_out: 0 buffer ulong[8] 0 36864 47104 41943040 35651584 131 5000000000 9223372036854775808
> > > > +# These values were choosen to exercise all code paths in the generic
> > > > +# implementation of __fixsfdi in compiler-rt:
> > > > +# https://github.com/llvm-mirror/compiler-rt/blob/master/lib/builtins/fixsfdi.c
> > > > +arg_in:  1 buffer float[8] 0x1.2p-5      \ # exp < 0
> > > > +                           0x1.2p+15     \ # pos exp <= 23
> > > > +                           0x1.7p+15     \ # pos exp <= 23
> > > > +                           0x1.4p25      \ # pos exp > 23
> > > > +                           0x1.1p25      \ # pos exp > 23
> > > > +                           131.35        \ # Random non-integer value
> > > > +                           5000000000.0  \ # Positive value requiring more than 32-bits
> > > > +                           9223372036854775808.0  # Positive value requiring 64-bits
> > > > +
> > > >  !*/
> > > >  
> > > > -kernel void test(global long *out, global float *in) {
> > > > +kernel void test_long(global long *out, global float *in) {
> > > >  	unsigned i;
> > > >  	for (i = 0; i < 8; i++) {
> > > >  		out[i] = convert_long(in[i]);
> > > >  	}
> > > >  }
> > > > +
> > > > +kernel void test_ulong(global ulong *out, global float *in) {
> > > > +	unsigned i;
> > > > +	for (i = 0; i < 8; i++) {
> > > > +		out[i] = convert_ulong(in[i]);
> > > > +	}
> > > > +}
> > > 
> > > -- 
> > > Jan Vesely <jan.vesely at rutgers.edu>
> > 
> > 
> > 
> > > _______________________________________________
> > > Piglit mailing list
> > > Piglit at lists.freedesktop.org
> > > http://lists.freedesktop.org/mailman/listinfo/piglit
> > 
> 
> -- 
> Jan Vesely <jan.vesely at rutgers.edu>




More information about the Piglit mailing list