[Piglit] [PATCH 1/6] [RFC] arb_gpu_shader_fp64: add initial generated tests (v3)

Dylan Baker baker.dylan.c at gmail.com
Fri Jul 25 17:20:41 PDT 2014

On Friday, July 25, 2014 08:14:22 PM Ilia Mirkin wrote:
> Something causes the tests to be generated in
> generated_tests/ARB_gpu_shader_fp64 instead of arb_gpu_shader_fp64
> like all the other tests (and like all.py expects... although it does
> seem to find the tests anyways, weird).

It would be great if the folder and test names could be all lower case.

> Also, on your piglit branch, you've augmented the packDouble case, I
> believe incorrectly. With
> uniform double expected_doub 2.122e-311
> uniform uvec2 given_uval 8519181 1000
> It passes for me though. And all the other tests do too... While I
> haven't reviewed the logic to generate these in detail, it does seem
> to work reasonably. The tests pass on nvc0 with my impl (didn't test
> against blob).
> For the series, with the above 2 minor issues fixed (ARB -> arb in
> generated dir name, fix your latest version of packDouble case),
> Acked-by: Ilia Mirkin <imirkin at alum.mit.edu>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20140725/86f40bc1/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20140725/86f40bc1/attachment.sig>

More information about the Piglit mailing list