[Piglit] [Patch v2 03/18] exectest.py: rename get_command_result to __run_command

Dylan Baker baker.dylan.c at gmail.com
Mon Jul 28 15:35:12 PDT 2014


This is shorter (and shorter is always better in a python), and it marks
the method as private (leading __) since it's only for use in a Test
method, not in it's children.

Signed-off-by: Dylan Baker <baker.dylan.c at gmail.com>
---
 framework/exectest.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/framework/exectest.py b/framework/exectest.py
index ca4ddf4..dcace25 100644
--- a/framework/exectest.py
+++ b/framework/exectest.py
@@ -155,7 +155,7 @@ class Test(object):
         # https://bugzilla.gnome.org/show_bug.cgi?id=680214 is affecting many
         # developers. If we catch it happening, try just re-running the test.
         for _ in xrange(5):
-            self.get_command_result()
+            self.__run_command()
             if "Got spurious window resize" not in self.result['out']:
                 break
 
@@ -194,7 +194,7 @@ class Test(object):
         """
         return False
 
-    def get_command_result(self):
+    def __run_command(self):
         # Set the environment for the tests. Use the default settings created
         # in the Options constructor first, then use any user defined
         # variables, finally, use any variables set for the test in the test
-- 
2.0.2



More information about the Piglit mailing list