[Piglit] [Patch v2 14/18] gleantest.py: fix is_skip()

Dylan Baker baker.dylan.c at gmail.com
Mon Jul 28 15:35:23 PDT 2014


Gleantest skipping was implemented in PiglitTest, which is not an
ancestor of GleanTest, so it would never be triggered.

It also was set to skip only on 'gbm', however glean only runs on glx,
so if the platform isn't glx then it should be skipped.

Signed-off-by: Dylan Baker <baker.dylan.c at gmail.com>
---
 framework/gleantest.py | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/framework/gleantest.py b/framework/gleantest.py
index 703eb3f..1af1897 100644
--- a/framework/gleantest.py
+++ b/framework/gleantest.py
@@ -52,3 +52,9 @@ class GleanTest(Test):
             self.result['result'] = 'fail'
         else:
             self.result['result'] = 'pass'
+
+    def is_skip(self):
+        # Glean tests require glx
+        if self.OPTS.env['PIGLIT_PLATFORM'] not in ['glx', 'mixed_glx_egl']:
+            return True
+        return super(GleanTest, self).is_skip()
-- 
2.0.2



More information about the Piglit mailing list