[Piglit] [Patch v2 17/18] exectest.py: split valgrind checking out of Test.run()

Dylan Baker baker.dylan.c at gmail.com
Mon Jul 28 15:35:26 PDT 2014


Test.run() is getting pretty long, splitting this out helps to reduce
that length and make the code more manageable.

Signed-off-by: Dylan Baker <baker.dylan.c at gmail.com>
---
 framework/exectest.py | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/framework/exectest.py b/framework/exectest.py
index 0787442..0b49c6a 100644
--- a/framework/exectest.py
+++ b/framework/exectest.py
@@ -189,6 +189,10 @@ class Test(object):
         elif self.result['returncode'] != 0 and self.result['result'] == 'pass':
             self.result['result'] = 'warn'
 
+        self.__interpret_valgrind()
+
+    def __interpret_valgrind(self):
+        """ If valgrind is used, set results for valgrind """
         if self.OPTS.valgrind:
             # If the underlying test failed, simply report
             # 'skip' for this valgrind test.
-- 
2.0.2



More information about the Piglit mailing list