[Piglit] [patch v3 13/15] arb_arrays_of_arrays/compiler/subroutine.vert: make parse correctly

Chris Forbes chrisf at ijw.co.nz
Mon Jul 28 19:39:34 PDT 2014


I haven't had time to examine your python changes in detail, but
patches 5, 9, 10, 13 (the ones that fix test headers) are:

Reviewed-by: Chris Forbes <chrisf at ijw.co.nz>

On Tue, Jul 29, 2014 at 12:34 PM, Dylan Baker <baker.dylan.c at gmail.com> wrote:
> This currently uses 3 require extensions lines, this doesn't actually
> work and never has, but with patches earlier in this series this stops
> parsing since the parser raises an error.
>
> Signed-off-by: Dylan Baker <baker.dylan.c at gmail.com>
> ---
>  tests/spec/arb_arrays_of_arrays/compiler/subroutine.vert | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/tests/spec/arb_arrays_of_arrays/compiler/subroutine.vert b/tests/spec/arb_arrays_of_arrays/compiler/subroutine.vert
> index f8d1402..32b1f7a 100644
> --- a/tests/spec/arb_arrays_of_arrays/compiler/subroutine.vert
> +++ b/tests/spec/arb_arrays_of_arrays/compiler/subroutine.vert
> @@ -1,9 +1,7 @@
>  /* [config]
>   * expect_result: pass
>   * glsl_version: 1.50
> - * require_extensions: GL_ARB_arrays_of_arrays
> - * require_extensions: GL_ARB_shader_subroutine
> - * require_extensions: GL_ARB_gpu_shader5
> + * require_extensions: GL_ARB_arrays_of_arrays GL_ARB_shader_subroutine GL_ARB_gpu_shader5
>   * [end config]
>   */
>  #version 150
> --
> 2.0.2
>
> _______________________________________________
> Piglit mailing list
> Piglit at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/piglit


More information about the Piglit mailing list