[Piglit] [PATCH 1/3] asmparsertest: print error if unable to open file

[Brian Paul]

On 06/01/2014 03:08 PM, Ilia Mirkin wrote:
> On Sun, Jun 1, 2014 at 5:03 PM, Brian Paul <brianp at vmware.com> wrote:
>> ---
>>   tests/asmparsertest/asmparsertest.c |    1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/tests/asmparsertest/asmparsertest.c b/tests/asmparsertest/asmparsertest.c
>> index 16ed0df..c250270 100644
>> --- a/tests/asmparsertest/asmparsertest.c
>> +++ b/tests/asmparsertest/asmparsertest.c
>> @@ -120,6 +120,7 @@ compile(const char *filename, GLenum target, int use_ARB)
>>
>>          buf = piglit_load_text_file(filename, &sz);
>>          if (buf == NULL) {
>> +               printf(stderr, "Failed to open %s\n", filename);
>
> Don't you want fprintf here? Or is there some crazy define situation
> going on here?
>

Oops, yes.  Thanks.

This typo happed when I was waffling between using printf() to stdout vs 
fprintf() to stderr.

 From what I see, Piglit's not very consistent in printf() vs. fprintf() 
for errors.  I don't know if any guidelines have ever been laid out.  I 
see both in test programs and in test harnesses like asmparsertest and 
shader_runner.  The output of both seem to get logged in the results file.

-Brian