[Piglit] [Patch v2] framework: Update results to use versioned numbers

Ilia Mirkin imirkin at alum.mit.edu
Fri Jun 6 13:57:28 PDT 2014

On Fri, Jun 6, 2014 at 4:54 PM, Dylan Baker <baker.dylan.c at gmail.com> wrote:
> Ilia, I've tested this with your use case, does seem reasonable?

The general idea seems reasonable, but I haven't had a chance to
actually review or test myself. Do you have this in a branch somewhere
so I can play with it? Or if you just want to push, we can fix up any
issues later... whatever.

> On Thursday, June 05, 2014 04:33:00 PM Dylan Baker wrote:
>> This patch updates our json to version 1. Changes from version 0 to
>> version 1 are as follows:
>> - renamed 'main' to 'results.json'
>> - dmesg must be a string (It was stored a list in some version 0
>>   results)
>> - subtests are never stored as duplicate entries, a single instance of
>>   the test is recorded, (In version 0 both are possible)
>> - there is no info entry in version 1, err, out, and returncode are
>>   always split into seperate entries
>> This patch adds support to the results module for handling updates to
>> the results in a sane way. It does this by adding a result_version
>> attribute to the TestrunResult (which is stored as json), and
>> implementing the ability to incrementally update results between
>> versions.
>> It does this automatically on load, non-destructively, moving the old
>> results to results.json.old, but does write the updated results to disk,
>> making the cost of this update a one time cost.
>> v2: - Handle non-writable directories and files, this also fixes using
>>       file-descriptors as inputs
>> Signed-off-by: Dylan Baker <baker.dylan.c at gmail.com>
>> ---
> [snip]

More information about the Piglit mailing list