[Piglit] [Patch v2] framework: Update results to use versioned numbers

[Ilia Mirkin]

On Fri, Jun 6, 2014 at 5:02 PM, Dylan Baker <baker.dylan.c at gmail.com> wrote:
> On Friday, June 06, 2014 04:57:28 PM Ilia Mirkin wrote:
>> On Fri, Jun 6, 2014 at 4:54 PM, Dylan Baker <baker.dylan.c at gmail.com> wrote:
>> > Ilia, I've tested this with your use case, does seem reasonable?
>>
>> The general idea seems reasonable, but I haven't had a chance to
>> actually review or test myself. Do you have this in a branch somewhere
>> so I can play with it? Or if you just want to push, we can fix up any
>> issues later... whatever.
>>
>> > On Thursday, June 05, 2014 04:33:00 PM Dylan Baker wrote:
>> >> This patch updates our json to version 1. Changes from version 0 to
>> >> version 1 are as follows:
>> >>
>> >> - renamed 'main' to 'results.json'
>> >> - dmesg must be a string (It was stored a list in some version 0
>> >>
>> >>   results)
>> >>
>> >> - subtests are never stored as duplicate entries, a single instance of
>> >>
>> >>   the test is recorded, (In version 0 both are possible)
>> >>
>> >> - there is no info entry in version 1, err, out, and returncode are
>> >>
>> >>   always split into seperate entries
>> >>
>> >> This patch adds support to the results module for handling updates to
>> >> the results in a sane way. It does this by adding a result_version
>> >> attribute to the TestrunResult (which is stored as json), and
>> >> implementing the ability to incrementally update results between
>> >> versions.
>> >>
>> >> It does this automatically on load, non-destructively, moving the old
>> >> results to results.json.old, but does write the updated results to disk,
>> >> making the cost of this update a one time cost.
>> >>
>> >> v2: - Handle non-writable directories and files, this also fixes using
>> >>
>> >>       file-descriptors as inputs
>> >>
>> >> Signed-off-by: Dylan Baker <baker.dylan.c at gmail.com>
>> >> ---
>> >
>> > [snip]
>
> doh! I specifically pushed it to a branch and then forgot to put that in my
> cover letter.
> https://github.com/dcbaker/piglit versioned-results-v4

Hm, just checked out that branch, this is what I get:

$ python ~/src/piglit/piglit-summary-html.py -e pass -e skip
nvc0-comparison <(xzcat nvcf-2014-04-20-mupuf.xz) <(xzcat
nve7-2014-06-06-mupuf-gs5.xz) <(xzcat gk208-2014-06-07-mupuf-gs5.xz)
--overwrite
Traceback (most recent call last):
  File "/home/ilia/src/piglit/piglit-summary-html.py", line 26, in <module>
    from framework.programs.summary import html
  File "/home/ilia/src/piglit/framework/programs/summary.py", line 26,
in <module>
    import framework.summary as summary
  File "/home/ilia/src/piglit/framework/summary.py", line 258, in <module>
    class Summary:
  File "/home/ilia/src/piglit/framework/summary.py", line 266, in Summary
    TEMPLATE_DIR = path.join(os.environ['PIGLIT_SOURCE_DIR'], 'templates')
  File "/usr/lib64/python2.7/UserDict.py", line 23, in __getitem__
    raise KeyError(key)
KeyError: 'PIGLIT_SOURCE_DIR'

Operator error of some sort? I tried rebuilding piglit in case there
was some sort of compile-time-created dependency, but that didn't
help.

  -ilia