[Piglit] [PATCH 4/5] cl: Add isnotequal(float, float) relational tests

Tom Stellard tom at stellard.net
Thu Jun 12 16:32:50 PDT 2014


On Wed, Jun 11, 2014 at 02:14:14PM -0500, Aaron Watry wrote:
> Signed-off-by: Aaron Watry <awatry at gmail.com>
> ---
>  generated_tests/generate-cl-relational-builtins.py | 12 +++++++++++-
>  1 file changed, 11 insertions(+), 1 deletion(-)
> 
> diff --git a/generated_tests/generate-cl-relational-builtins.py b/generated_tests/generate-cl-relational-builtins.py
> index 97e6be6..f22f5d1 100644
> --- a/generated_tests/generate-cl-relational-builtins.py
> +++ b/generated_tests/generate-cl-relational-builtins.py
> @@ -32,7 +32,8 @@ from genclbuiltins import gen, TRUE
>  CLC_VERSION_MIN = {
>      'isnan' : 10,
>      'isgreater' : 10,
> -    'isgreaterequal' : 10
> +    'isgreaterequal' : 10,
> +    'isnotequal' : 10,
>  }
>  
>  DATA_TYPES = ['float']
> @@ -71,6 +72,15 @@ tests = {
>              [0.0,  float("nan"), 1.0,  1,            float("nan"), float("inf"), 1.0,  0.5 ], # Arg0
>              [0.0,  float("nan"), 1.0,  float("nan"), 1,            float("inf"), 0.5,  1.0 ]  # Arg1
>          ]
> +    },
> +    'isnotequal' : {
> +        'arg_types': [I, F, F],
> +        'function_type': 'ttt',
> +        'values': [
> +            [0,    TRUE,         0,    TRUE,         TRUE,         0,            TRUE, TRUE],    # Result

I think comparisons involving nan are always false, so the three nan
cases should be changed to 0.  You might want to double check this,
though.

-Tom

> +            [0.0,  float("nan"), 1.0,  1,            float("nan"), float("inf"), 1.0,  0.5 ], # Arg0
> +            [0.0,  float("nan"), 1.0,  float("nan"), 1,            float("inf"), 0.5,  1.0 ]  # Arg1
> +        ]
>      }
>  }
>  
> -- 
> 1.9.1
> 


More information about the Piglit mailing list