[Piglit] piglit-summary-html.py currently broken

[Dylan Baker]

On Monday, June 16, 2014 12:32:35 PM Ian Romanick wrote:
> When I run piglit-summary-html.py, it crashes with the following trace:
> 
> Traceback (most recent call last):
>   File "./piglit-summary-html.py", line 28, in <module>
>     html(sys.argv[1:])
>   File "/home/idr/devel/graphics/piglit/framework/programs/summary.py", line
> 97, in html output.generate_html(args.summaryDir, args.exclude_details)
>   File "/home/idr/devel/graphics/piglit/framework/summary.py", line 436, in
> generate_html module_directory=self.TEMP_DIR)
>   File "/usr/lib/python2.7/site-packages/mako/template.py", line 224, in
> __init__ module = self._compile_from_file(path, filename)
>   File "/usr/lib/python2.7/site-packages/mako/template.py", line 250, in
> _compile_from_file path)
>   File "/usr/lib/python2.7/site-packages/mako/template.py", line 513, in
> _compile_module_file node = lexer.parse()
>   File "/usr/lib/python2.7/site-packages/mako/lexer.py", line 211, in parse
>     if self.match_control_line():
>   File "/usr/lib/python2.7/site-packages/mako/lexer.py", line 400, in
> match_control_line self.append_node(parsetree.ControlLine, keyword, isend,
> text)
>   File "/usr/lib/python2.7/site-packages/mako/lexer.py", line 125, in
> append_node node = nodecls(*args, **kwargs)
>   File "/usr/lib/python2.7/site-packages/mako/parsetree.py", line 72, in
> __init__ code = ast.PythonFragment(text, **self.exception_kwargs)
>   File "/usr/lib/python2.7/site-packages/mako/ast.py", line 90, in __init__
>     super(PythonFragment, self).__init__(code, **exception_kwargs)
>   File "/usr/lib/python2.7/site-packages/mako/ast.py", line 39, in __init__
>     f.visit(expr)
>   File "/usr/lib/python2.7/site-packages/mako/_ast_util.py", line 279, in
> visit return self.generic_visit(node)
>   File "/usr/lib/python2.7/site-packages/mako/_ast_util.py", line 287, in
> generic_visit self.visit(item)
>   File "/usr/lib/python2.7/site-packages/mako/_ast_util.py", line 278, in
> visit return f(node)
>   File "/usr/lib/python2.7/site-packages/mako/pyparser.py", line 143, in
> visit_For self.visit(node.iter)
>   File "/usr/lib/python2.7/site-packages/mako/_ast_util.py", line 279, in
> visit return self.generic_visit(node)
>   File "/usr/lib/python2.7/site-packages/mako/_ast_util.py", line 287, in
> generic_visit self.visit(item)
>   File "/usr/lib/python2.7/site-packages/mako/_ast_util.py", line 279, in
> visit return self.generic_visit(node)
>   File "/usr/lib/python2.7/site-packages/mako/_ast_util.py", line 289, in
> generic_visit self.visit(value)
>   File "/usr/lib/python2.7/site-packages/mako/_ast_util.py", line 278, in
> visit return f(node)
>   File "/usr/lib/python2.7/site-packages/mako/pyparser.py", line 107, in
> visit_Lambda self._visit_function(node, True)
>   File "/usr/lib/python2.7/site-packages/mako/pyparser.py", line 125, in
> _visit_function if arg_id(arg) in self.local_ident_stack:
> AttributeError: 'Tuple' object has no attribute 'id'
> 
> I bisected this to the following commit:
> 
> commit 6755d9195bc05bbee2445eeac6af6b0e0ecf5160
> Author: Thomas Wood <thomas.wood at intel.com>
> Date:   Wed Jun 4 11:07:30 2014 +0100
> 
>     templates: add the totals to testrun_info
> 
>     Add the totals to the testrun_info template, including the total number
>     of tests evaluated.
> 
>     Signed-off-by: Thomas Wood <thomas.wood at intel.com>
>     Reviewed-by: Dylan Baker <baker.dylan.c at gmail.com>

I cannot replicate this bug, can you upload your results files somewhere or 
send them to me?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20140616/bd7d35cd/attachment.sig>