[Piglit] [PATCH 1/2] arb_shader_atomic_counters: get log from the right shader

Ilia Mirkin imirkin at alum.mit.edu
Tue Jun 17 09:40:55 PDT 2014


Thanks. Any chance you could also look at the other pair? (Which adds
the PASTE thing and switches the GS check to look for version 3.2
instead of ARB_geometry_shader4.)

On Tue, Jun 17, 2014 at 5:44 AM, Chris Forbes <chrisf at ijw.co.nz> wrote:
> These two are both:
>
> Reviewed-by: Chris Forbes <chrisf at ijw.co.nz>
>
> On Tue, Jun 17, 2014 at 5:06 PM, Ilia Mirkin <imirkin at alum.mit.edu> wrote:
>> ---
>>
>> Not sure why this doesn't use the generic piglit functions for this, but this
>> fixes log retrieval on nvidia blob.
>>
>>  tests/spec/arb_shader_atomic_counters/common.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/tests/spec/arb_shader_atomic_counters/common.c b/tests/spec/arb_shader_atomic_counters/common.c
>> index 34fee32..7547d5d 100644
>> --- a/tests/spec/arb_shader_atomic_counters/common.c
>> +++ b/tests/spec/arb_shader_atomic_counters/common.c
>> @@ -71,9 +71,9 @@ atomic_counters_compile(GLuint prog, GLuint stage, const char *src)
>>          if (status) {
>>                  glAttachShader(prog, shader);
>>          } else {
>> -                glGetShaderiv(prog, GL_INFO_LOG_LENGTH, &log_size);
>> +                glGetShaderiv(shader, GL_INFO_LOG_LENGTH, &log_size);
>>                  log = malloc(log_size);
>> -                glGetShaderInfoLog(prog, log_size, NULL, log);
>> +                glGetShaderInfoLog(shader, log_size, NULL, log);
>>
>>                  printf("Failed to compile shader: %s\n", log);
>>                  printf("source:\n%s", src);
>> --
>> 1.8.5.5
>>
>> _______________________________________________
>> Piglit mailing list
>> Piglit at lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/piglit


More information about the Piglit mailing list