[Piglit] [PATCH 1/2] arb_shader_atomic_counters: fix gs support check

Francisco Jerez currojerez at riseup.net
Thu Jun 19 03:45:10 PDT 2014


Ilia Mirkin <imirkin at alum.mit.edu> writes:

> ---
>
> Not actually an issue on the blob, since it supports ARB_geometry_shader4, but
> Chris Forbes pointed it out. This also works.
>
>  tests/spec/arb_shader_atomic_counters/common.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/spec/arb_shader_atomic_counters/common.c b/tests/spec/arb_shader_atomic_counters/common.c
> index 7547d5d..95d809e 100644
> --- a/tests/spec/arb_shader_atomic_counters/common.c
> +++ b/tests/spec/arb_shader_atomic_counters/common.c
> @@ -211,7 +211,7 @@ atomic_counters_supported(GLenum shader_stage)
>                  return n;
>  
>          case GL_GEOMETRY_SHADER:
> -                if (piglit_is_extension_supported("GL_ARB_geometry_shader4"))
> +                if (piglit_get_gl_version() >= 32)

Wouldn't this do the wrong thing on e.g. an implementation of GL3.1 that
exposes ARB_geometry_shader4?

>                          glGetIntegerv(GL_MAX_GEOMETRY_ATOMIC_COUNTERS, &n);
>                  return n;
>  
> -- 
> 1.8.5.5
>
> _______________________________________________
> Piglit mailing list
> Piglit at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/piglit
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 229 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20140619/01c261b3/attachment.sig>


More information about the Piglit mailing list