[Piglit] [PATCH] cl: Fix out-of-bounds write in get-num-groups

Tom Stellard tom at stellard.net
Wed Jun 25 07:16:55 PDT 2014


On Wed, Jun 25, 2014 at 12:35:50PM +0200, Lars-Dominik Braun wrote:
> ---
> Each work-item writes three values. 4*4*4*3 is 192.

Reviewed-by: Tom Stellard <thomas.stellard at amd.com>

I can commit this.

-Tom

> 
> I’m new to piglit and do not have commit access.
> 
>  tests/cl/program/execute/get-num-groups.cl | 16 ++++++++++++----
>  1 file changed, 12 insertions(+), 4 deletions(-)
> 
> diff --git a/tests/cl/program/execute/get-num-groups.cl b/tests/cl/program/execute/get-num-groups.cl
> index 20e4b7a..803411b 100644
> --- a/tests/cl/program/execute/get-num-groups.cl
> +++ b/tests/cl/program/execute/get-num-groups.cl
> @@ -76,7 +76,9 @@ kernel_name: fill3d
>  dimensions: 3
>  global_size: 4 4 4
>  local_size: 1 1 1
> -arg_out: 0 buffer int[144] 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 \
> +arg_out: 0 buffer int[192] 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 \
> +                           4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 \
> +                           4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 \
>                             4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 \
>                             4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 \
>                             4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 \
> @@ -89,7 +91,9 @@ kernel_name: fill3d
>  dimensions: 3
>  global_size: 4 4 4
>  local_size: 2 2 2
> -arg_out: 0 buffer int[144] 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 \
> +arg_out: 0 buffer int[192] 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 \
> +                           2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 \
> +                           2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 \
>                             2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 \
>                             2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 \
>                             2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 \
> @@ -102,7 +106,9 @@ kernel_name: fill3d
>  dimensions: 3
>  global_size: 4 4 4
>  local_size: 4 4 4
> -arg_out: 0 buffer int[144] 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 \
> +arg_out: 0 buffer int[192] 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 \
> +                           1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 \
> +                           1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 \
>                             1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 \
>                             1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 \
>                             1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 \
> @@ -115,7 +121,9 @@ kernel_name: fill3d
>  dimensions: 3
>  global_size: 4 4 4
>  local_size: 4 2 1
> -arg_out: 0 buffer int[144] 1 2 4 1 2 4 1 2 4 1 2 4 1 2 4 1 2 4 1 2 4 1 2 4 \
> +arg_out: 0 buffer int[192] 1 2 4 1 2 4 1 2 4 1 2 4 1 2 4 1 2 4 1 2 4 1 2 4 \
> +                           1 2 4 1 2 4 1 2 4 1 2 4 1 2 4 1 2 4 1 2 4 1 2 4 \
> +                           1 2 4 1 2 4 1 2 4 1 2 4 1 2 4 1 2 4 1 2 4 1 2 4 \
>                             1 2 4 1 2 4 1 2 4 1 2 4 1 2 4 1 2 4 1 2 4 1 2 4 \
>                             1 2 4 1 2 4 1 2 4 1 2 4 1 2 4 1 2 4 1 2 4 1 2 4 \
>                             1 2 4 1 2 4 1 2 4 1 2 4 1 2 4 1 2 4 1 2 4 1 2 4 \
> -- 
> 1.8.5.5
> 
> _______________________________________________
> Piglit mailing list
> Piglit at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/piglit


More information about the Piglit mailing list