[Piglit] [PATCH] cmake: Require Mako >= 0.7

[Dylan Baker]

On Thursday, June 26, 2014 05:52:53 PM Chad Versace wrote:
> On Wed, Jun 25, 2014 at 10:24:42PM -0700, Dylan Baker wrote:
> > On Wednesday, June 25, 2014 08:47:24 PM Chad Versace wrote:
> > > +set(__MAKO_CHECK_VERSION_PY "
> > > +try:
> > > +	import mako
> > > +except ImportError as err:
> > > +	import sys
> > > +	sys.exit(err)
> > 
> > I'm pretty sure that this isn't going to do what you want. sys.exit()
> > takes an interger argument as an exit code, but I'm pretty sure that in
> > this case err is going to be a string 'no module named mako'
> 
> Me and Dyland talked about this in person. If x is not an int, and you
> call sys.exit(x), then Python prints repr(x) to stderr and then calls
> sys.exit(1).

Yes,

Reviewed-by: Dylan Baker <baker.dylan.c at gmail.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20140626/9cd2d7f7/attachment.sig>