[Piglit] libepoxy conversion v2

[Eric Anholt]

Jordan Justen <jljusten at gmail.com> writes:

> On Fri, Mar 7, 2014 at 9:12 PM, Eric Anholt <eric at anholt.net> wrote:
>> Jose Fonseca <jfonseca at vmware.com> writes:
>>
>>> ----- Original Message -----
>>>> On Wed, Feb 26, 2014 at 10:30 AM, Ken Phillis Jr <kphillisjr at gmail.com>
>>>> wrote:
>>>> >
>>>> > On Feb 25, 2014 3:45 PM, Brian Paul wrote:
>>>> >> I haven't had time to look at these changes, nor libepoxy.  But it's
>>>> >> critical to us that piglit continues to work on Windows.
>>>> >>
>>>> > I just checked libepoxy against MSVC2010 and it is a total mess. I
>>>> > recommend
>>>> > a rewrite since proper windows support depends on properly supporting the
>>>> > Visual Studio.
>>>>
>>>> Is this feedback based on trying to build libepoxy with VS2010, or
>>>> trying to build piglit with VS2010 with Eric's released libepoxy
>>>> binaries?
>>>
>>> I only noticed this thread now.
>>>
>>> Where are these libepoxy windows binaries? I searched piglit archives
>>> but couldn't find them.
>>
>> In the release:
>>
>> https://github.com/anholt/libepoxy/releases
>>
>> (epoxy-1.1-win32.zip)
>>
>>> The thing with Windows binaries is that only .h + .dll (dynamic libs)
>>> are portable.  .h + .lib (static libraries) end up being tied to the
>>> particular MSVC compiler version and build type
>>
>> Here's what's in the 1.1 tarball:
>>
>> /home/anholt/epoxy-1.1-win32
>> /home/anholt/epoxy-1.1-win32/win64
>> /home/anholt/epoxy-1.1-win32/win64/lib
>> /home/anholt/epoxy-1.1-win32/win64/lib/libepoxy.dll.a
>> /home/anholt/epoxy-1.1-win32/win64/lib/pkgconfig
>> /home/anholt/epoxy-1.1-win32/win64/lib/pkgconfig/epoxy.pc
>> /home/anholt/epoxy-1.1-win32/win64/lib/libepoxy.la
>> /home/anholt/epoxy-1.1-win32/win64/bin
>> /home/anholt/epoxy-1.1-win32/win64/bin/libepoxy-0.dll
>> /home/anholt/epoxy-1.1-win32/include
>> /home/anholt/epoxy-1.1-win32/include/epoxy
>> /home/anholt/epoxy-1.1-win32/include/epoxy/gl_generated.h
>> /home/anholt/epoxy-1.1-win32/include/epoxy/gl.h
>> /home/anholt/epoxy-1.1-win32/win32
>> /home/anholt/epoxy-1.1-win32/win32/lib
>> /home/anholt/epoxy-1.1-win32/win32/lib/libepoxy.dll.a
>> /home/anholt/epoxy-1.1-win32/win32/lib/pkgconfig
>> /home/anholt/epoxy-1.1-win32/win32/lib/pkgconfig/epoxy.pc
>> /home/anholt/epoxy-1.1-win32/win32/lib/libepoxy.la
>> /home/anholt/epoxy-1.1-win32/win32/bin
>> /home/anholt/epoxy-1.1-win32/win32/bin/libepoxy-0.dll
>>
>> I'm really interested in seeing if you can make use of the releases.
>
> I setup a functioning piglit build on Windows with MSVC. (Yea, such fun!)
>
> I then tried building your branch using the libepoxy binaries. I found
> 2 main issues.
>
> 1. pkg-config dependency added to piglit for libepoxy. I think I have
> a patch for this.
> 2. gl_generated.h has compilation issues with MSVC. (Of course...)
>
> For 2, I guess Ken Phillis Jr. may have some (rough?) libepoxy patches.

Wow, thanks Jordan!

I took a brief look at Ken's MSVC megapatch, but it introduced a bunch
of codegen-time differences for windows, where I want platform
differentiation to be #ifdeffed in the generated code itself (think
about all of the users of libraries like this who just copy it into
their trees -- they won't want to replicate the codegen, and just copy
the codegenned files instead).

I've been hoping to get to doing the MSVC codegen changes this week.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 818 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20140311/9e467c01/attachment.pgp>