[Piglit] [PATCH 0/3] ARB_explicit_uniform_location initial tests

Ian Romanick idr at freedesktop.org
Wed Mar 12 11:07:00 PDT 2014


On 03/12/2014 04:22 AM, Tapani Pälli wrote:
> Hi;
> 
> Here are first tests for the ARB_explicit_uniform_location extension.
> My plan is to continue writing more execution type of tests which test 
> setting and getting of locations and different corner cases. This set 
> is for the basic functionality part.

These tests look good to me.  I eagerly await the others. :)

Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>

> These are skipped with current Mesa as it does not have the extension, 
> however they can be exercised with following branch if wanted:
> 
> http://cgit.freedesktop.org/~tpalli/mesa/log/?h=exp_uniform_loc
> 
> 
> Tapani Pälli (3):
>   ARB_explicit_uniform_location: preprocessor define test
>   ARB_explicit_uniform_location: location qualifier compiler test
>   ARB_explicit_uniform_location: GL_MAX_UNIFORM_LOCATIONS enum test
> 
>  tests/all.py                                       |  8 +++
>  tests/spec/CMakeLists.txt                          |  1 +
>  .../CMakeLists.gl.txt                              | 12 +++++
>  .../arb_explicit_uniform_location/CMakeLists.txt   |  1 +
>  .../compiler/layout-01.frag                        | 18 +++++++
>  .../compiler/layout-01.vert                        | 15 ++++++
>  tests/spec/arb_explicit_uniform_location/minmax.c  | 58 ++++++++++++++++++++++
>  .../preprocessor/define.frag                       | 19 +++++++
>  .../preprocessor/define.vert                       | 19 +++++++
>  9 files changed, 151 insertions(+)
>  create mode 100644 tests/spec/arb_explicit_uniform_location/CMakeLists.gl.txt
>  create mode 100644 tests/spec/arb_explicit_uniform_location/CMakeLists.txt
>  create mode 100644 tests/spec/arb_explicit_uniform_location/compiler/layout-01.frag
>  create mode 100644 tests/spec/arb_explicit_uniform_location/compiler/layout-01.vert
>  create mode 100644 tests/spec/arb_explicit_uniform_location/minmax.c
>  create mode 100644 tests/spec/arb_explicit_uniform_location/preprocessor/define.frag
>  create mode 100644 tests/spec/arb_explicit_uniform_location/preprocessor/define.vert
> 



More information about the Piglit mailing list