[Piglit] [PATCH 1/2] KHR_debug: Support GLES2

[Felipe Tonello]

Hi Fabian,

On Tue, Mar 11, 2014 at 5:24 PM, Fabian Bieler <fabianbieler at fastmail.fm> wrote:
> Hello!
>
> Sync objects, vertex arrays, queries, transform feedback objects and sampler
> objects are not supported by gles2.

Ok. But then how would this extension work with GLES2? I don't see
anywhere in the spec saying what's the minimum requirement for OpenGL
ES. It only states that requires OpenGL 1.1.

For exemple, glObjectPtrLabel requires a sync object. So only this
type of call will not work with OpenGL ES 2.0? Or the whole extension?

> ProgramPipeline objects and display lists are only supported by desktop gl.
> #ifdef-hell, here we go again ;)
>
> Sorry for not picking up on these problems in my first review.

No problem. :)

>
> Be sure to test sync objects in gles3 regardless of the presence of the
> GL_ARB_sync extension.

Ok. Also based on the documentation glFenceSync() is from OpenGL 3.2
even without the extension. So I can probably send this small patch
for now.

>
> Also you may want to use the PFNGL*PROC types for the function pointers
> (e.g.: PFNGLOBJECTLABELPROC), but I'm not sure that would actually improve
> readability, so leaving these as-is is fine by me. :)

I don't like the OpenGL way of naming callbacks either. :)

Felipe