[Piglit] [PATCH 5/7] ARB_explicit_uniform_location: test overlapping locations
Tapani Pälli
tapani.palli at intel.com
Thu Mar 13 23:00:40 PDT 2014
On 03/14/2014 02:12 AM, Anuj Phogat wrote:
> On Thu, Mar 13, 2014 at 5:41 AM, Tapani Pälli <tapani.palli at intel.com> wrote:
>> This test tests overlapping uniform locations across shader stages.
>>
>> Signed-off-by: Tapani Pälli <tapani.palli at intel.com>
>> ---
>> tests/all.py | 1 +
>> .../CMakeLists.gl.txt | 1 +
>> .../arb_explicit_uniform_location/loc-overlap.c | 89 ++++++++++++++++++++++
>> 3 files changed, 91 insertions(+)
>> create mode 100644 tests/spec/arb_explicit_uniform_location/loc-overlap.c
>>
>> diff --git a/tests/all.py b/tests/all.py
>> index 0cfffc2..26b8818 100644
>> --- a/tests/all.py
>> +++ b/tests/all.py
>> @@ -1929,6 +1929,7 @@ add_plain_test(arb_explicit_uniform_location, 'arb_explicit_uniform_location-bou
>> add_plain_test(arb_explicit_uniform_location, 'arb_explicit_uniform_location-array-elements')
>> add_plain_test(arb_explicit_uniform_location, 'arb_explicit_uniform_location-array-toobig')
>> add_plain_test(arb_explicit_uniform_location, 'arb_explicit_uniform_location-array-overlap')
>> +add_plain_test(arb_explicit_uniform_location, 'arb_explicit_uniform_location-loc-overlap')
>>
>> arb_texture_buffer_object = Group()
>> spec['ARB_texture_buffer_object'] = arb_texture_buffer_object
>> diff --git a/tests/spec/arb_explicit_uniform_location/CMakeLists.gl.txt b/tests/spec/arb_explicit_uniform_location/CMakeLists.gl.txt
>> index 3ca4018..c5adb89 100644
>> --- a/tests/spec/arb_explicit_uniform_location/CMakeLists.gl.txt
>> +++ b/tests/spec/arb_explicit_uniform_location/CMakeLists.gl.txt
>> @@ -14,3 +14,4 @@ piglit_add_executable (arb_explicit_uniform_location-boundaries loc-minmax.c)
>> piglit_add_executable (arb_explicit_uniform_location-array-elements array-elements.c)
>> piglit_add_executable (arb_explicit_uniform_location-array-toobig array-toobig.c)
>> piglit_add_executable (arb_explicit_uniform_location-array-overlap array-overlap.c)
>> +piglit_add_executable (arb_explicit_uniform_location-loc-overlap loc-overlap.c)
>> diff --git a/tests/spec/arb_explicit_uniform_location/loc-overlap.c b/tests/spec/arb_explicit_uniform_location/loc-overlap.c
>> new file mode 100644
>> index 0000000..ba95358
>> --- /dev/null
>> +++ b/tests/spec/arb_explicit_uniform_location/loc-overlap.c
>> @@ -0,0 +1,89 @@
>> +/*
>> + * Copyright © 2014 Intel Corporation
>> + *
>> + * Permission is hereby granted, free of charge, to any person obtaining a
>> + * copy of this software and associated documentation files (the "Software"),
>> + * to deal in the Software without restriction, including without limitation
>> + * the rights to use, copy, modify, merge, publish, distribute, sublicense,
>> + * and/or sell copies of the Software, and to permit persons to whom the
>> + * Software is furnished to do so, subject to the following conditions:
>> + *
>> + * The above copyright notice and this permission notice (including the next
>> + * paragraph) shall be included in all copies or substantial portions of the
>> + * Software.
>> + *
>> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
>> + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
>> + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
>> + * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
>> + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
>> + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
>> + * IN THE SOFTWARE.
>> + */
>> +
>> +/**
>> + * \file loc-overlap.c
>> + *
>> + * Tests overlapping uniform location among 2 shader stages, both shaders
>> + * define same explicit location. Note, this test does not include testing
>> + * for overlaps with unused uniform locations.
>> + *
>> + * https://www.opengl.org/registry/specs/ARB/explicit_uniform_location.txt
>> + *
>> + * Specification states : "No two default-block uniform variables in the
>> + * program can have the same location, even if they are
>> + * unused, otherwise a compiler or linker error will be
>> + * generated."
>> + */
>> +#include "piglit-util-gl-common.h"
>> +
>> +PIGLIT_GL_TEST_CONFIG_BEGIN
>> +
>> + config.supports_gl_compat_version = 20;
>> + config.window_visual = PIGLIT_GL_VISUAL_RGB;
>> +
>> +PIGLIT_GL_TEST_CONFIG_END
>> +
>> +enum piglit_result
>> +piglit_display(void)
>> +{
>> + return PIGLIT_FAIL;
>> +}
>> +
>> +const char v_sha[] =
>> +"#extension GL_ARB_explicit_uniform_location: require\n"
>> +"layout(location = 42) uniform vec4 offset;\n"
> We don't know what's the maximum uniform locations supported
> on different platforms other than Intel. So, it'll be safer to use a
> smaller number for the location.
1024 is the minimum required value for this enum though, there is also a
check for this in earlier test "GL_MAX_UNIFORM_LOCATIONS enum test' so
42 should be fine here.
>> +"vec4 vertex;\n"
>> +"void main() {\n"
>> +"gl_Position = vertex + offset;\n"
>> +"}";
>> +
>> +const char f_sha[] =
>> +"#extension GL_ARB_explicit_uniform_location: require\n"
>> +"layout(location = 42) uniform vec4 color;\n"
>> +"void main() {\n"
>> +"gl_FragColor = color;\n"
>> +"}";
>> +
>> +static bool
>> +test()
>> +{
>> + GLuint prog;
>> + GLint link_status;
>> +
>> + prog = piglit_build_simple_program_unlinked(v_sha, f_sha);
>> +
>> + glLinkProgram(prog);
>> + glGetProgramiv(prog, GL_LINK_STATUS, &link_status);
>> + glDeleteProgram(prog);
>> +
>> + /* link_status is expected to be GL_FALSE */
>> + return !link_status;
>> +}
>> +
>> +void
>> +piglit_init(int argc, char **argv)
>> +{
>> + piglit_require_extension("GL_ARB_explicit_uniform_location");
>> + piglit_report_result(test() ? PIGLIT_PASS : PIGLIT_FAIL);
>> +}
>> --
>> 1.8.3.1
>>
>> _______________________________________________
>> Piglit mailing list
>> Piglit at lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/piglit
More information about the Piglit
mailing list