[Piglit] [PATCH 2/4] copyteximage: add ARB_depth_texture dependencies

Marek Olšák maraeo at gmail.com
Sun Mar 16 07:39:20 PDT 2014


Okay, nevermind then.

Marek

On Sun, Mar 16, 2014 at 3:24 PM, Ilia Mirkin <imirkin at alum.mit.edu> wrote:
> It does not appear to be tested. If you look in the test_vectors array:
>
> { GL_DEPTH_COMPONENT,   fcolor[7] },
> { GL_DEPTH_COMPONENT16, fcolor[7] },
> { GL_DEPTH_COMPONENT24, fcolor[7] },
> { GL_DEPTH_COMPONENT32F, fcolor[7] },
>
> { GL_DEPTH24_STENCIL8, fcolor[7] },
> { GL_DEPTH32F_STENCIL8, fcolor[7] },
>
>
> On Sun, Mar 16, 2014 at 10:03 AM, Marek Olšák <maraeo at gmail.com> wrote:
>> Did you forget GL_DEPTH_COMPONENT32 or is it not tested by this test?
>>
>> Marek
>>
>> On Thu, Mar 13, 2014 at 5:07 PM, Ilia Mirkin <imirkin at alum.mit.edu> wrote:
>>> Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu>
>>> ---
>>>  tests/texturing/copyteximage.c | 7 ++++++-
>>>  1 file changed, 6 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/tests/texturing/copyteximage.c b/tests/texturing/copyteximage.c
>>> index 0afcba5..85b2215 100644
>>> --- a/tests/texturing/copyteximage.c
>>> +++ b/tests/texturing/copyteximage.c
>>> @@ -184,8 +184,13 @@ supported_format(GLenum format)
>>>         case GL_COMPRESSED_RED:
>>>         case GL_COMPRESSED_RG:
>>>                 return piglit_is_extension_supported("GL_ARB_texture_rg");
>>> +       case GL_DEPTH_COMPONENT:
>>> +       case GL_DEPTH_COMPONENT16:
>>> +       case GL_DEPTH_COMPONENT24:
>>> +               return piglit_is_extension_supported("GL_ARB_depth_texture");
>>>         case GL_DEPTH24_STENCIL8:
>>> -               return piglit_is_extension_supported("GL_EXT_packed_depth_stencil");
>>> +               return piglit_is_extension_supported("GL_EXT_packed_depth_stencil") &&
>>> +                       piglit_is_extension_supported("GL_ARB_depth_texture");
>>>         case GL_DEPTH_COMPONENT32F:
>>>         case GL_DEPTH32F_STENCIL8:
>>>                 return piglit_is_extension_supported("GL_ARB_depth_buffer_float");
>>> --
>>> 1.8.3.2
>>>
>>> _______________________________________________
>>> Piglit mailing list
>>> Piglit at lists.freedesktop.org
>>> http://lists.freedesktop.org/mailman/listinfo/piglit


More information about the Piglit mailing list