[Piglit] [PATCH] framework/log.py: print a final summary line after a run has finished

Dylan Baker baker.dylan.c at gmail.com
Thu Mar 20 09:33:58 PDT 2014


On Thursday, March 20, 2014 16:04:59 Thomas Wood wrote:
> Signed-off-by: Thomas Wood <thomas.wood at intel.com>
> ---
>  framework/log.py | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/framework/log.py b/framework/log.py
> index c15134b..fc37001 100644
> --- a/framework/log.py
> +++ b/framework/log.py
> @@ -93,6 +93,10 @@ class Log(object):
>          assert result in self.__summary_keys
>          self.__summary[result] += 1
> 
> +        # print a final summary line
> +        if self.__complete == self.__total:
> +            self.__print(value, result)
> +
>      @synchronized_self
>      def log(self, name, result):
>          """ Print to the screen

IMHO, it would better to add a final call method (or modify Log.post_log to 
have only keyword arguments) that just prints [x/y] and the summary (ie: 
[8/8] pass: 7 fail: 1) that we add to TestProfile.run. That would remove the 
Running Test(s) as well.

I'm seeing some weird artifiacts from this:
master: [15/16] pass: 13, skip: 2 Running Test(s): 14 14 15 15
patch:  [16/16] pass: 14, skip: 2 Running Test(s): 14 15 15 1508
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20140320/ee847aac/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20140320/ee847aac/attachment.sig>


More information about the Piglit mailing list