[Piglit] [PATCH] framework/log.py: print a final summary line after a run has finished

Dylan Baker baker.dylan.c at gmail.com
Thu Mar 20 11:46:13 PDT 2014


On Thursday, March 20, 2014 18:23:58 Thomas Wood wrote:
> On 20 March 2014 16:33, Dylan Baker <baker.dylan.c at gmail.com> 
wrote:
> > On Thursday, March 20, 2014 16:04:59 Thomas Wood wrote:
> > 
> > 
> > 
> > IMHO, it would better to add a final call method (or modify Log.post_log
> > to
> > have only keyword arguments) that just prints [x/y] and the summary 
(ie:
> > [8/8] pass: 7 fail: 1) that we add to TestProfile.run. That would remove
> > the Running Test(s) as well.
> > 
> > 
> > 
> > I'm seeing some weird artifiacts from this:
> > 
> > master: [15/16] pass: 13, skip: 2 Running Test(s): 14 14 15 15
> > 
> > patch: [16/16] pass: 14, skip: 2 Running Test(s): 14 15 15 1508
> 
> There are a couple of problems with artefacts at the moment,
> particularly in verbose mode. I think this is down to the line not
> being cleared when the summary is updated, which means that if the 
new
> output is shorter then the characters from the previous output remain
> visible.
> 
> Regards,
> 
> Thomas

I think there are three distinct places we get artifacts:
1: when we switch from concurrent to non-concurrent runs there will be 
(cores-1) "Running Test(s)" left behind
2: When the line becomes so long it wraps there is significant issues, but 
on verbose and non verbose
3: if the new output is shorter than the old output

I had put this off since I had hoped to move to python3, and it has a 
function to get the width of the terminal, and my plan was to pad out the 
end with blank spaces and slice the output string to be no longer than the 
width of the terminal. but the python3 stuff is not moving quickly, so I 
should probably come up with a solution that works for python2
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20140320/af4bd7af/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20140320/af4bd7af/attachment.sig>


More information about the Piglit mailing list