[Piglit] [PATCH 11/15] arb_tessellation_shader: Negative test mismatching shader and primitive type.

Fabian Bieler fabianbieler at fastmail.fm
Mon Mar 24 15:02:50 PDT 2014


>From the ARB_tessellation_shader spec (Errors section):

   "The error INVALID_OPERATION is generated by Begin (or vertex array
    commands that implicitly call Begin) if the active program contains a
    tessellation control or evaluation shader and the primitive mode is not
    PATCHES.

    The error INVALID_OPERATION is generated by Begin (or vertex array
    commands that implicitly call Begin) if the primitive mode is PATCHES if
    either:

      *  the active program contains no tessellation evaluation shader, or
      *  no program is active."

Signed-off-by: Fabian Bieler <fabianbieler at fastmail.fm>
---
 tests/all.py                                       |   1 +
 .../spec/arb_tessellation_shader/CMakeLists.gl.txt |   1 +
 .../arb_tessellation_shader/invalid-primitive.c    | 157 +++++++++++++++++++++
 3 files changed, 159 insertions(+)
 create mode 100644 tests/spec/arb_tessellation_shader/invalid-primitive.c

diff --git a/tests/all.py b/tests/all.py
index bf58b90..dc0c2d7 100644
--- a/tests/all.py
+++ b/tests/all.py
@@ -1441,6 +1441,7 @@ spec['ARB_tessellation_shader'] = arb_tessellation_shader
 add_concurrent_test(arb_tessellation_shader, 'arb_tessellation_shader-get')
 add_concurrent_test(arb_tessellation_shader, 'arb_tessellation_shader-get-tcs-params')
 add_concurrent_test(arb_tessellation_shader, 'arb_tessellation_shader-get-tes-params')
+add_concurrent_test(arb_tessellation_shader, 'arb_tessellation_shader-invalid-primitive')
 import_glsl_parser_tests(arb_tessellation_shader,
                          os.path.join(testsDir, 'spec',
                          'arb_tessellation_shader'), ['compiler'])
diff --git a/tests/spec/arb_tessellation_shader/CMakeLists.gl.txt b/tests/spec/arb_tessellation_shader/CMakeLists.gl.txt
index 8d8369d..5a65452 100644
--- a/tests/spec/arb_tessellation_shader/CMakeLists.gl.txt
+++ b/tests/spec/arb_tessellation_shader/CMakeLists.gl.txt
@@ -12,5 +12,6 @@ link_libraries (
 piglit_add_executable (arb_tessellation_shader-get get.c)
 piglit_add_executable (arb_tessellation_shader-get-tcs-params get-tcs-params.c)
 piglit_add_executable (arb_tessellation_shader-get-tes-params get-tes-params.c)
+piglit_add_executable (arb_tessellation_shader-invalid-primitive invalid-primitive.c)
 
 # vim: ft=cmake:
diff --git a/tests/spec/arb_tessellation_shader/invalid-primitive.c b/tests/spec/arb_tessellation_shader/invalid-primitive.c
new file mode 100644
index 0000000..cf45301
--- /dev/null
+++ b/tests/spec/arb_tessellation_shader/invalid-primitive.c
@@ -0,0 +1,157 @@
+/*
+ * Copyright © 2014 Intel Corporation
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a
+ * copy of this software and associated documentation files (the "Software"),
+ * to deal in the Software without restriction, including without limitation
+ * the rights to use, copy, modify, merge, publish, distribute, sublicense,
+ * and/or sell copies of the Software, and to permit persons to whom the
+ * Software is furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice (including the next
+ * paragraph) shall be included in all copies or substantial portions of the
+ * Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
+ * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
+ * IN THE SOFTWARE.
+ */
+
+/**
+ * \file invalid-primitive.c
+ *
+ * From the ARB_tessellation_shader spec (Errors section):
+ *
+ *  "The error INVALID_OPERATION is generated by Begin (or vertex array
+ *  commands that implicitly call Begin) if the active program contains a
+ *  tessellation control or evaluation shader and the primitive mode is not
+ *  PATCHES.
+ *
+ *  The error INVALID_OPERATION is generated by Begin (or vertex array
+ *  commands that implicitly call Begin) if the primitive mode is PATCHES if
+ *  either:
+ *
+ *    *  the active program contains no tessellation evaluation shader, or
+ *    *  no program is active."
+ *
+ * Test for all those errors except without active program.
+ */
+
+#include "piglit-util-gl-common.h"
+
+PIGLIT_GL_TEST_CONFIG_BEGIN
+
+	config.supports_gl_compat_version = 32;
+	config.supports_gl_core_version = 32;
+
+PIGLIT_GL_TEST_CONFIG_END
+
+
+static const char *const vs_source =
+"#version 150\n"
+"void main() { gl_Position = vec4(0.0); }\n";
+
+static const char *const tcs_source =
+"#version 150\n"
+"#extension GL_ARB_tessellation_shader: require\n"
+"layout(vertices = 3) out;\n"
+"void main() { gl_out[gl_InvocationID].gl_Position = vec4(0.0); }\n";
+
+static const char *const tes_source =
+"#version 150\n"
+"#extension GL_ARB_tessellation_shader: require\n"
+"layout(triangles) in;\n"
+"void main() { gl_Position = vec4(0.0); }\n";
+
+static const char *const fs_source =
+"#version 150\n"
+"void main() { gl_FragColor = vec4(0.0); }\n";
+
+
+void
+piglit_init(int argc, char **argv)
+{
+	bool pass = true;
+	int i;
+	unsigned int vao, tcs_prog, tes_prog, normal_prog;
+	static const GLenum primitive[] = {
+		GL_POINTS,
+		GL_LINES,
+		GL_LINE_LOOP,
+		GL_LINE_STRIP,
+		GL_TRIANGLES,
+		GL_TRIANGLE_STRIP,
+		GL_TRIANGLE_FAN,
+		GL_LINES_ADJACENCY,
+		GL_LINE_STRIP_ADJACENCY,
+		GL_TRIANGLES_ADJACENCY,
+		GL_TRIANGLE_STRIP_ADJACENCY,
+	};
+
+	piglit_require_extension("GL_ARB_tessellation_shader");
+
+	glGenVertexArrays(1, &vao);
+	glBindVertexArray(vao);
+
+	tcs_prog = piglit_build_simple_program_multiple_shaders(
+			GL_VERTEX_SHADER, vs_source,
+			GL_TESS_CONTROL_SHADER, tcs_source,
+			GL_FRAGMENT_SHADER, fs_source,
+			0);
+	tes_prog = piglit_build_simple_program_multiple_shaders(
+			GL_VERTEX_SHADER, vs_source,
+			GL_TESS_EVALUATION_SHADER, tes_source,
+			GL_FRAGMENT_SHADER, fs_source,
+			0);
+	normal_prog = piglit_build_simple_program_multiple_shaders(
+			GL_VERTEX_SHADER, vs_source,
+			GL_FRAGMENT_SHADER, fs_source,
+			0);
+
+	for (i = 0; i < ARRAY_SIZE(primitive); ++i) {
+		glUseProgram(tcs_prog);
+		pass = piglit_check_gl_error(GL_NO_ERROR) && pass;
+		glDrawArrays(primitive[i], 0, 12);
+		pass = piglit_check_gl_error(GL_INVALID_OPERATION) && pass;
+	}
+
+	for (i = 0; i < ARRAY_SIZE(primitive); ++i) {
+		glUseProgram(tes_prog);
+		pass = piglit_check_gl_error(GL_NO_ERROR) && pass;
+		glDrawArrays(primitive[i], 0, 12);
+		pass = piglit_check_gl_error(GL_INVALID_OPERATION) && pass;
+	}
+
+	/* NV_gpu_shader5 allows drawing patches without tessellation
+	 * evaluation shader.
+	 */
+	if (!piglit_is_extension_supported("GL_NV_gpu_shader5")) {
+		glUseProgram(normal_prog);
+		pass = piglit_check_gl_error(GL_NO_ERROR) && pass;
+		glDrawArrays(GL_PATCHES, 0, 12);
+		pass = piglit_check_gl_error(GL_INVALID_OPERATION) && pass;
+	}
+
+	glUseProgram(0);
+	glDeleteProgram(tcs_prog);
+	glDeleteProgram(tes_prog);
+	glDeleteProgram(normal_prog);
+	glBindVertexArray(0);
+	glDeleteVertexArrays(1, &vao);
+
+	pass = piglit_check_gl_error(GL_NO_ERROR) && pass;
+
+	piglit_report_result(pass ? PIGLIT_PASS : PIGLIT_FAIL);
+}
+
+
+enum piglit_result
+piglit_display(void)
+{
+	return PIGLIT_PASS;
+}
+
-- 
1.8.3.2



More information about the Piglit mailing list