[Piglit] [Patch v2 10/11] exectest.py: Merge Test and ExecTest into a single class

Dylan Baker baker.dylan.c at gmail.com
Thu Mar 27 17:06:26 PDT 2014


On Thursday, March 27, 2014 17:01:24 Dylan Baker wrote:
> On Thursday, March 27, 2014 15:34:03 Dylan Baker wrote:
> > Rather than have 2 base classes, let's just have one.
> > 
> > v2: - remove test that no longer is valid
> > 
> > Signed-off-by: Dylan Baker <baker.dylan.c at gmail.com>
> > ---
> > 
> >  framework/exectest.py            | 26 +++++++++-----------------
> >  framework/gleantest.py           | 12 ++++++------
> >  framework/gtest.py               |  4 ++--
> >  framework/tests/exectest_test.py |  7 +------
> >  tests/es3conform.py              |  8 +++++---
> >  tests/igt.py                     |  7 ++++---
> >  tests/oglconform.py              |  7 ++++---
> >  7 files changed, 31 insertions(+), 40 deletions(-)
> > 
[snip]

Sorry for the empty email, my mail client got itself into a state.

Anyway:
there are three bugs in this patch;
1) igt still returns ExecTest instead of Test
2) piglit-print-command.py still checks for ExecTest instances instead 
of Test
3) Test has two implementations of run.

I have fixed all of these already, and the changes are pushed to github 
already.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20140327/d1d1d5e9/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20140327/d1d1d5e9/attachment.sig>


More information about the Piglit mailing list