[Piglit] [PATCH 0/3] Update piglit install locations

[Dylan Baker]

On Friday, May 02, 2014 12:41:03 Jordan Justen wrote:
> On Fri, May 2, 2014 at 12:50 AM, Dylan Baker <baker.dylan.c at gmail.com> wrote:
> > I think patches 1 and 2 look good. You have my r-b on those.
> 
> Thanks. Can you add your r-b to the patches in your branch, since I
> expect you'd push them with your swapped out follow on patches?
> 
> > I have a branch here: https://github.com/dcbaker/piglit piglit-cmd
> > that IMO has a more elegant solution for a piglit executable.
> > The big advantages I see to my approach is that there is very little
> > hand rolled code, we don't need cmake to populate any data for us,
> > and it works in all three use cases (not built, not installed;
> > built, not installed; built, installed).
> >
> > I have tested my piglit in all three applications and it works for me,
> >
> > would you have a look?
> 
> It looks pretty good. Less 'git' like than my version, but it works for me.
> 
> Reviewed-by: Jordan Justen <jordan.l.justen at intel.com>
> for a567e14 framework: move executable functions to modules.
> 
> For 982121f piglit: Add a toplevel piglit command:
> 
> May not need this, since that was to enable @PYTHON_EXECUTABLE@ in piglit.in:
> set(PythonInterp_FIND_VERSION 2)
> find_package(PythonInterp REQUIRED)
> 
> Rather than '../lib/piglit', could you use path.join('..', 'lib',
> path.basename(sys.argv[0]))?

sure.

> 
> Is there a way to install piglit as:
> piglit${PIGLIT_INSTALL_VERSION_SUFFIX}
> 
> My thought is someone could package piglit as piglit-version-foo and
> then regression test against that version. (And be able to install
> multiple versions.

I assume we could do that, but what would that change do other than 
making the command harder to use, since it installs
${install_root}/{lib,bin,share} with no version string, what would be
the point?

> 
> Thanks,
> 
> -Jordan
> 
> > On Wednesday, April 30, 2014 10:28:54 Jordan Justen wrote:
> >
> >> Move piglit binaries and libraries out of the system paths
> >
> >>
> >
> >> Add a piglit wrapper command to easily run piglit commands
> >
> >> in the new install location
> >
> >>
> >
> >> git://people.freedesktop.org/~jljusten/piglit piglit-cmd
> >
> >>
> >
> >> Jordan Justen (3):
> >
> >> cmake: Install under separate piglit directory
> >
> >> cmake: Add version suffix for install paths
> >
> >> piglit: Add piglit command
> >
> >>
> >
> >> CMakeLists.txt | 43 ++++++++++++++++++----
> >
> >> cmake/piglit_util.cmake | 4 +--
> >
> >> piglit.in | 42 ++++++++++++++++++++++
> >
> >> piglit_cmd.py | 96 +++++++++++++++++++++++++++++++++++++++++++++++++
> >
> >> 4 files changed, 177 insertions(+), 8 deletions(-)
> >
> >> create mode 100755 piglit.in
> >
> >> create mode 100755 piglit_cmd.py
> >
> >>
> >
> >>
> >
> >
> >
> >
> > _______________________________________________
> > Piglit mailing list
> > Piglit at lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/piglit
> >

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20140502/673acef3/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20140502/673acef3/attachment-0001.sig>