[Piglit] [PATCH 0/4] Update piglit install locations v2

Dylan Baker baker.dylan.c at gmail.com
Fri May 2 18:31:27 PDT 2014

I didn't like Jordan's initial approach to the python code of the piglit
binary. This series is his original two patches, with two patches of my
own to replace the third.

Patch 1 moves the contents of piglit-*.py to python modules, and
replaces them with wrapper that import functions from those modules and
call them.

Patch 2 adds a toplevel piglit wrapper that also uses the functions from
the modules, and uses argparse to wrap them. 

The advantages of my piglit implementation are that it uses argparse, so
it will have the same feel as the other argument parsers in piglit, it
also doesn't require any handrolled code, just a few
argparse.ArgumentParser() instances. It also doesn't need to be
configured by cmake, so it can be used even without compiling (for
example, when using the summary functionality), and it can be used
without installing.

Jose: does this look reasonable to you? I tested with an in tree build,
and an out of tree build.

Dylan Baker (2):
  framework: move executable functions to modules
  piglit: Add a toplevel piglit command

Jordan Justen (2):
  cmake: Install under separate piglit directory
  cmake: Add version suffix for install paths

 CMakeLists.txt                 |  44 +++++---
 cmake/piglit_util.cmake        |   4 +-
 framework/programs/__init__.py |   0
 framework/programs/run.py      | 242 ++++++++++++++++++++++++++++++++++++++++
 framework/programs/summary.py  | 243 +++++++++++++++++++++++++++++++++++++++++
 piglit                         |  88 +++++++++++++++
 piglit-resume.py               | 108 ++++--------------
 piglit-run.py                  | 199 ++++-----------------------------
 piglit-summary-html.py         | 113 ++++---------------
 piglit-summary-junit.py        | 161 ++++-----------------------
 piglit-summary.py              |  93 ++++------------
 11 files changed, 706 insertions(+), 589 deletions(-)
 create mode 100644 framework/programs/__init__.py
 create mode 100644 framework/programs/run.py
 create mode 100644 framework/programs/summary.py
 create mode 100755 piglit


More information about the Piglit mailing list